Perf | avoid copying of an array for SqlBinary in TdsParser (dotnet#2308

) follow up changes for PR dotnet#1934
Intrigma · Jan 19, 2024 · e269e15 · e269e15
1 parent f1282f4
commit e269e15
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
@@ -5957,7 +5957,11 @@ internal bool DeserializeUnencryptedValue(SqlBuffer value, byte[] unencryptedByt
                             unencryptedBytes = bytes;
                         }
 
-                        value.SqlBinary = new SqlBinary(unencryptedBytes);   // doesn't copy the byte array
+#if NET7_0_OR_GREATER
+                        value.SqlBinary = SqlBinary.WrapBytes(unencryptedBytes);
+#else
+                        value.SqlBinary = SqlTypeWorkarounds.SqlBinaryCtor(unencryptedBytes, true);   // doesn't copy the byte array
+#endif
                         break;
                     }