Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Edge errors #100

Merged
merged 8 commits into from
Aug 5, 2024
Merged

fix: handle Edge errors #100

merged 8 commits into from
Aug 5, 2024

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jul 23, 2024

Proposed Changes

Extends error response processing to handle Edge (OSS) errors as well. It sets InfluxDBError.message value from either message (Cloud) or data.error_message / error (Edge) element value in the response body when an error occurs.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

Sorry, something went wrong.

@alespour alespour force-pushed the fix/handle-edge-errors branch from 81a6fb4 to 245fecc Compare July 23, 2024 07:01
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.34%. Comparing base (70ceac0) to head (bc5fde1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   53.26%   54.34%   +1.08%     
==========================================
  Files          33       33              
  Lines        2037     2046       +9     
==========================================
+ Hits         1085     1112      +27     
+ Misses        952      934      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review July 23, 2024 07:06
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

LGTM 🚀

@alespour alespour merged commit 9fd9ebc into main Aug 5, 2024
13 checks passed
@alespour alespour deleted the fix/handle-edge-errors branch August 5, 2024 09:21
@bednar bednar added this to the 0.8.0 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants