fix: catch babel parse errors #198
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfaith
commented
Jan 12, 2025
| const ast = babelParser(code, parserOptions); | ||
| let ast; | ||
| try { | ||
| ast = babelParser(code, parserOptions); |
There was a problem hiding this comment.
I said in the original issue that it was babel.traverse that was throwing, but I mispoke; it was actually the parse that happens first. So, I only wrapped the parse itself.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This change updates the plugin to catch babel parsing errors, so that we can give prettier a chance to throw. We're still writing an error to console, so that in the event that prettier doesn't end up throwing, we're still indicating that the import sorting failed.
michaelfaith
force-pushed
the
fix/catch-babel-parse-errors
branch
from
939e461 to
26a54f0
Compare
Co-authored-by: Frederic Barthelemy <github@fbartho.com>
|
Thanks a ton, @michaelfaith, this will be very helpful. |
IanVS
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the plugin to catch babel parsing errors, so that we can give prettier a chance to throw. We're still writing an error to console, so that in the event that prettier doesn't end up throwing, we're still indicating that the import sorting failed.
Closes #197