Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ repo-wide upgrade to aiohttp==3.8.5 #4544

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 25, 2023

What do these changes do?

Master deploy presents sporadic errors in the web-server logged as

Task exception was never retrieved
future: <Task finished name='Task-262869' coro=<RequestHandler.start() done, defined at /home/scu/.venv/lib/python3.10/site-packages/aiohttp/web_protocol.py:462> exception=AttributeError("'NoneType' object has no attribute 'get_extra_info'")>
Traceback (most recent call last):
  File "/home/scu/.venv/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 505, in start
    request = self._request_factory(message, payload, self, writer, handler)
  File "/home/scu/.venv/lib/python3.10/site-packages/aiohttp/web_app.py", line 446, in _make_request
    return _cls(
  File "/home/scu/.venv/lib/python3.10/site-packages/aiohttp/web_request.py", line 811, in __init__
    super().__init__(*args, **kwargs)
  File "/home/scu/.venv/lib/python3.10/site-packages/aiohttp/web_request.py", line 189, in __init__
    self._transport_sslcontext = transport.get_extra_info("sslcontext")
AttributeError: 'NoneType' object has no attribute 'get_extra_info'

Highlights on updated libraries (only updated libraries are included)

  • #packages before: 7
  • #packages after : 7
# name before after upgrade count packages
1 aiohttp 3.8.4, 3.8.3 3.8.5 13 agent⬆️🧪
api-server⬆️
autoscaling⬆️
catalog⬆️🧪
datcore-adapter⬆️
invitations⬆️
resource-usage-tracker⬆️
storage⬆️🧪
web⬆️🧪
2 click 8.1.3 8.1.6 2 osparc-gateway-server🧪🧪
3 fsspec 2023.5.0 2023.6.0 minor 1 osparc-gateway-server🧪
4 importlib-metadata 6.6.0 6.8.0 minor 1 osparc-gateway-server🧪
5 markupsafe 2.1.2 2.1.3 1 osparc-gateway-server🧪
6 tblib 1.7.0 2.0.0 MAJOR 1 osparc-gateway-server🧪
7 zipp 3.15.0 3.16.2 minor 1 osparc-gateway-server🧪

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

Related issue/s

How to test

DevOps Checklist

@codeclimate
Copy link

codeclimate bot commented Jul 25, 2023

Code Climate has analyzed commit c914390 and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov self-assigned this Jul 25, 2023
@pcrespov pcrespov added this to the Sundae milestone Jul 25, 2023
@pcrespov pcrespov added dependencies Pull requests that update a dependency file t:maintenance Some planned maintenance work labels Jul 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #4544 (c914390) into master (dbcc0f4) will decrease coverage by 18.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4544      +/-   ##
=========================================
- Coverage    88.4%   69.6%   -18.8%     
=========================================
  Files         517     265     -252     
  Lines       25472   13294   -12178     
  Branches      530       0     -530     
=========================================
- Hits        22519    9260   -13259     
- Misses       2823    4034    +1211     
+ Partials      130       0     -130     
Flag Coverage Δ
integrationtests 62.8% <ø> (-5.6%) ⬇️
unittests 64.9% <ø> (-21.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 381 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit e20bd93 into ITISFoundation:master Jul 25, 2023
50 checks passed
@pcrespov pcrespov deleted the maintenance/upgrade-aiohttp branch July 25, 2023 21:15
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants