Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): retry MockBroker Listen for EADDRINUSE #2721

Merged
merged 1 commit into from Jan 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 21 additions & 1 deletion mockbroker.go
Expand Up @@ -10,6 +10,7 @@ import (
"reflect"
"strconv"
"sync"
"syscall"
"time"

"github.com/davecgh/go-spew/spew"
Expand Down Expand Up @@ -410,10 +411,29 @@ func NewMockBroker(t TestReporter, brokerID int32) *MockBroker {
// NewMockBrokerAddr behaves like newMockBroker but listens on the address you give
// it rather than just some ephemeral port.
func NewMockBrokerAddr(t TestReporter, brokerID int32, addr string) *MockBroker {
listener, err := net.Listen("tcp", addr)
var (
listener net.Listener
err error
)

// retry up to 20 times if address already in use (e.g., if replacing broker which hasn't cleanly shutdown)
for i := 0; i < 20; i++ {
listener, err = net.Listen("tcp", addr)
if err != nil {
if errors.Is(err, syscall.EADDRINUSE) {
Logger.Printf("*** mockbroker/%d waiting for %s (address already in use)", brokerID, addr)
time.Sleep(time.Millisecond * 100)
continue
}
t.Fatal(err)
}
break
}

if err != nil {
t.Fatal(err)
}

return NewMockBrokerListener(t, brokerID, listener)
}

Expand Down