Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): ensure some more clients are closed #2595

Merged
merged 2 commits into from
Aug 12, 2023
Merged

fix(test): ensure some more clients are closed #2595

merged 2 commits into from
Aug 12, 2023

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Aug 11, 2023

No description provided.

dnwe added 2 commits August 12, 2023 00:29
We don't want to keep the tcp conn alive as we only make very few
requests and it'll show up as a leaked goroutine in-between tests.

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@dnwe dnwe merged commit 868ed33 into main Aug 12, 2023
@dnwe dnwe deleted the dnwe/close branch August 12, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant