Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup AS400Varchar byte conversions and parameter validation #122

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fixup AS400Varchar byte conversions and parameter validation #122

merged 1 commit into from
Aug 15, 2023
+20 −60

Conversation

ThePrez
Copy link
Member

@ThePrez ThePrez commented Aug 15, 2023

Summary of changes:

  • Removed incorrect Javadoc asserting that input strings must be space-padded (presumably carried over from AS400Text)
  • Added stricter parameter validation for the size of the length field
  • Added stricter parameter validation to make sure the data will "fit" with the given length field size
  • Corrected logic bugs related to conversion into bytes

@ThePrez
Fixup AS400Varchar byte conversions and parameter validation
17e4c9e 
Signed-off-by: Jesse Gorzinski <17914061+ThePrez@users.noreply.github.com>
@ThePrez ThePrez merged commit 5d99727 into IBM:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ThePrez