Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added primary_ip refernce to nac for consistency #5847

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Dec 4, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #5827

Output from acceptance testing:

% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstance_primary_ip_consistency'
=== RUN   TestAccIBMISInstance_primary_ip_consistency
--- PASS: TestAccIBMISInstance_primary_ip_consistency (168.92s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     170.892s

@uibm uibm marked this pull request as ready for review December 5, 2024 04:48
@uibm
Copy link
Collaborator Author

uibm commented Dec 5, 2024

image image

@hkantare hkantare merged commit 67161fe into IBM-Cloud:master Dec 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibm_is_instance: different data structure between resource and data source
2 participants