Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CrossHair backend in the CI #3928

Conversation

JonathanPlasse
Copy link
Contributor

@JonathanPlasse JonathanPlasse commented Mar 17, 2024

get hypothesis-crosshair running in our CI

Is this what you had in mind for #3914

@Zac-HD
Copy link
Member

Zac-HD commented Mar 18, 2024

Not quite - adding the tox + CI task yes, but as well as adding a new set of tests I want to try running all the existing tests using crosshair. I think that will involve setting up a new profile in hypothesis-python/tests/common/setup.py, then enabling it via an environment variable, and finally running the usual cover/nocover/niche tests.

The point of this exercise is not that all the tests will work - some of the internals tests shouldn't, on an alternative backend. The point is to discover various problems where we want to fail gracefully and currently just fail. Depending on how many and how serious they are, we'll decide what to run in CI and what we'll just revisit later 🙂

@JonathanPlasse JonathanPlasse force-pushed the add-crosshair-in-ci branch 2 times, most recently from 2bc80fd to 1b88227 Compare March 23, 2024 08:30
@Zac-HD
Copy link
Member

Zac-HD commented Mar 24, 2024

I've ultimately cherry-picked these changes into #3935, but left them disabled in CI due to the current high failure rate.

Thanks again for working on this!

@Zac-HD Zac-HD closed this Mar 24, 2024
@JonathanPlasse JonathanPlasse deleted the add-crosshair-in-ci branch March 24, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants