Add min_magnitude & max_magnitude passthrough in complex-valued from_dtype()

[felixdivo]

Closes #3468.

[felixdivo]

There is again a problem with RELEASE.rst. 🙃

[honno]

Really appreciate you working on these issues :)

Things are looking good! I'll have a proper look later on if Zac doesn't get round to it heh.

Also ICYMI, you can use ./build.sh format at the root of the repository to run the linters locally.

[Zac-HD]

A few comments left, but this looks great - thanks again Felix!

[Zac-HD]

OK, looks like there's one remaining test failure due to this new passthrough logic for width.

• here, adding , ids=repr to the parametrize call will let us tell which dtype caused the problem
• I think then we want to limit the width argument to the underlying strategy as we do for floats here, so that we can e.g. generate complex128 elements and store them in a complex256 array.

[felixdivo]

There is again a problem with RELEASE.rst. 🙃

This is still the case.

Should I change anything else?

[Zac-HD]

Ah, you'll need to create that file with your changelog entry for this PR. I'd suggest something like:

RELEASE_TYPE: minor

This release allows for more precise generation of complex numbers using
:func:`~hypothesis.extra.numpy.from_dtype`, by supporting the ``width``,
``min_magnitude``, and ``min_magnitude`` arguments (:issue:`3468`).

Thanks to Felix Divo for this feature!

The underlying cause: it looks like you branched off from a point where we'd merged a previous PR to master, but not yet finished deploying that release. This is a known issue but we can't easily fix it until merge queues are available 😥 - until then we'll just have to deal with occasionally rebasing or fixing merge conflicts by hand.

[felixdivo]

Ah, you'll need to create that file with your changelog entry for this PR.

@Zac-HD I now replaced the currently present file. I hope that was correct. I don't have sufficient access rights to resolve the conflict though ^^.

And thanks for the kind note. 😊

[Zac-HD]

Not quite - you'll need to git switch master; git pull upstream master ; git switch - ; git rebase master (or git merge master, but that's uglier) and either way then fix the merge conflict 🙂

[felixdivo]

Resolved @Zac-HD :)

[Zac-HD]

🎉 let's ship it!