Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min/max magnitude arguments to from_dtype() strategy #3468

Closed
Zac-HD opened this issue Sep 30, 2022 · 1 comment · Fixed by #3570
Closed

Add min/max magnitude arguments to from_dtype() strategy #3468

Zac-HD opened this issue Sep 30, 2022 · 1 comment · Fixed by #3570
Assignees
@honno
Labels
enhancement it's not broken, but we want it to be better

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Sep 30, 2022

We pass through the arguments for other strategies, just not complex, and it might be useful for some people to fix that.
Original context: #3456 (comment)
@Zac-HD Zac-HD added the enhancement it's not broken, but we want it to be better label Sep 30, 2022
@Zac-HD Zac-HD mentioned this issue Nov 2, 2022
Closed
This was referenced Jan 25, 2023
Merged
Merged
@felixdivo
Copy link
Contributor

If anyone else is looking at this: I'll do this soon, btw.

@felixdivo felixdivo mentioned this issue Feb 4, 2023
Merged
Zac-HD added a commit that referenced this issue Feb 4, 2023
@Zac-HD
Merge pull request #3570 from felixdivo/from_dtype-complex-bounds
10b61a5 
Closes #3468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honno honno

Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add min_magnitude & max_magnitude passthrough in complex-valued from_dtype() felixdivo/hypothesis
3 participants
@felixdivo @honno @Zac-HD