Skip to content

Commit

Permalink
core/txpool/legacypool: remove redundant check for floatingRatio == 0 (
Browse files Browse the repository at this point in the history
…ethereum#27477)

floatingRatio is a constant and always non-zero. So there is no need to
check for == 0.
  • Loading branch information
hero5512 authored and devopsbo3 committed Nov 10, 2023
1 parent 082ff53 commit d97bfa6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/txpool/legacypool/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ func (l *pricedList) underpricedFor(h *priceHeap, tx *types.Transaction) bool {
func (l *pricedList) Discard(slots int, force bool) (types.Transactions, bool) {
drop := make(types.Transactions, 0, slots) // Remote underpriced transactions to drop
for slots > 0 {
if len(l.urgent.list)*floatingRatio > len(l.floating.list)*urgentRatio || floatingRatio == 0 {
if len(l.urgent.list)*floatingRatio > len(l.floating.list)*urgentRatio {
// Discard stale transactions if found during cleanup
tx := heap.Pop(&l.urgent).(*types.Transaction)
if l.all.GetRemote(tx.Hash()) == nil { // Removed or migrated
Expand Down

0 comments on commit d97bfa6

Please sign in to comment.