Skip to content

Commit

Permalink
Revert "eth/downloader: drop beacon head updates if the syncer is res…
Browse files Browse the repository at this point in the history
…tarting (ethereum#27397)"

This reverts commit 0968b3d.
  • Loading branch information
devopsbo3 committed Nov 10, 2023
1 parent 1d0027c commit 223b385
Showing 1 changed file with 7 additions and 25 deletions.
32 changes: 7 additions & 25 deletions eth/downloader/skeleton.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,31 +367,13 @@ func (s *skeleton) sync(head *types.Header) (*types.Header, error) {
s.filler.resume()
}
defer func() {
// The filler needs to be suspended, but since it can block for a while
// when there are many blocks queued up for full-sync importing, run it
// on a separate goroutine and consume head messages that need instant
// replies.
done := make(chan struct{})
go func() {
defer close(done)
if filled := s.filler.suspend(); filled != nil {
// If something was filled, try to delete stale sync helpers. If
// unsuccessful, warn the user, but not much else we can do (it's
// a programming error, just let users report an issue and don't
// choke in the meantime).
if err := s.cleanStales(filled); err != nil {
log.Error("Failed to clean stale beacon headers", "err", err)
}
}
}()
// Wait for the suspend to finish, consuming head events in the meantime
// and dropping them on the floor.
for {
select {
case <-done:
return
case event := <-s.headEvents:
event.errc <- errors.New("beacon syncer reorging")
if filled := s.filler.suspend(); filled != nil {
// If something was filled, try to delete stale sync helpers. If
// unsuccessful, warn the user, but not much else we can do (it's
// a programming error, just let users report an issue and don't
// choke in the meantime).
if err := s.cleanStales(filled); err != nil {
log.Error("Failed to clean stale beacon headers", "err", err)
}
}
}()
Expand Down

0 comments on commit 223b385

Please sign in to comment.