reprepro 5.4.4 #171471
Draft
reprepro 5.4.4 #171471
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
added
the
CI-no-fail-fast
github-actions
bot
added
automerge-skip
chenrui333
force-pushed
the
reprepro-5.4.4
branch
from
32d156f
to
1c6a66e
Compare
carlocab
reviewed
May 12, 2024
Closed
Signed-off-by: Rui Chen <rui@chenrui.dev> autobump: add reprepro Signed-off-by: Rui Chen <rui@chenrui.dev> reprepro: add upstream patch pr ref Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
reprepro-5.4.4
branch
from
1c6a66e
to
55bb623
Compare
carlocab
requested changes
May 12, 2024
Comment on lines
+39
to
+44
| # Replace strcmp2 with strcmp for consistent string comparison | ||
| # upstream patch PR, https://salsa.debian.org/debian/reprepro/-/merge_requests/10 | ||
| patch do | ||
| url "https://raw.githubusercontent.com/Homebrew/formula-patches/5426d605c0d6b6bf4c2e315fed7a991f447caf1a/reprepro/5.4.4-strcmp2.patch" | ||
| sha256 "cf1aacf08960cb89896a739086d170417820fe894044d0f446b4ff303a1182e5" | ||
| end |
There was a problem hiding this comment.
I don't think the patch is correct; it seems likely to result in UB: https://salsa.debian.org/debian/reprepro/-/blob/21a227f5fb380672ba022d47628895d2f023bde9/globals.h#L97
There was a problem hiding this comment.
yeah, I thought the same thing, I will debug a bit today.
There was a problem hiding this comment.
Maybe it's just missing an
include "globals.h"
somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?