fix(deps): update dependency @typescript-eslint/eslint-plugin to v6 #2844

renovate · 2023-07-23T03:08:16Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@typescript-eslint/eslint-plugin	`5.62.0` -> `6.2.1`

Release Notes

typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)

`v6.2.1`

Compare Source

Bug Fixes

eslint-plugin: [no-inferrable-types] apply also for parameter properties (#7288) (67f93b1)
scope-manager: correct decorators(.length) check in ClassVisitor for methods (#7334) (abbb6c2)

You can read about our versioning strategy and releases on our website.

`v6.2.0`

Compare Source

Bug Fixes

eslint-plugin: [member-ordering] account for repeated names (#6864) (d207b59)
eslint-plugin: [no-unsafe-enum-comparison] exempt bit shift operators (#7074) (b3e0e75)
eslint-plugin: [prefer-nullish-coalescing] handle case when type of left side is null or undefined (#7225) (b62affe)
eslint-plugin: use a default export for the rules type (#7266) (af77a1d)

Features

eslint-plugin: [class-methods-use-this] add extension rule (#6457) (18ea3b1)
eslint-plugin: sync getFunctionHeadLoc implementation with upstream (#7260) (f813147)

You can read about our versioning strategy and releases on our website.

`v6.1.0`

Compare Source

Bug Fixes

eslint-plugin: [comma-dangle] fixed crash from undefined predicate.ignore (#7223) (d368164)
eslint-plugin: [no-floating-promises] false negative calling .then with second argument undefined (#6881) (606a52c), closes #6850
eslint-plugin: [no-floating-promises] finally should be transparent to unhandled promises (#7092) (2a4421c)
eslint-plugin: [no-unnecessary-type-constraint] correctly fix in cts/mts files (#6795) (1404796)
eslint-plugin: [no-unused-vars] check if any variable definition is exported (#6873) (587ac30), closes #6188
eslint-plugin: fix schemas across several rules and add schema tests (#6947) (dd31bed)
eslint-plugin: include the rules types in the package (#7215) (a3da11d)

Features

typescript-estree: add EXPERIMENTAL_useProjectService option to use TypeScript project service (#6754) (6d3d162)

You can read about our versioning strategy and releases on our website.

`v6.0.0`

Compare Source

Bug Fixes

bumped ts-api-utils to 0.0.39 (#6497) (217c710)
correct handling of additionalProperties in object schemas (#6939) (489c7a5)
correct lint error after merge (277fdb5)
eslint-plugin: [explicit-module-boundary-types] remove shouldTrackReferences option from schema (#5399) (6d32734)
eslint-plugin: allow parser@^6.0.0 (#6630) (92908bd)
eslint-plugin: remove valid-typeof disable in eslint-recommended (#5381) (b82df5e)
fix illegal decorator check (#6723) (c456f8c)
rename typeParameters to typeArguments where needed (#5384) (08d757b)
replace tsutils with ts-api-tools (#6428) (79327b4)
type-utils: treat intrinsic types as if they are from lib and never match error types (#6869) (ecb57de)
typescript-estree: account for namespace nesting in AST conversion (#6272) (09e3877)
update exports field in package.json files (#6550) (53776c2)

chore

drop support for node v14.17, v17 (#5971) (cc62015)

Features

add new package rule-tester (#6777) (2ce1c1d)
add package.json exports for public packages (#6458) (d676683)
bump minimum supported TS version to 4.2.4 (#5915) (a8e71d5)
bump ts-api-utils to v0.0.21 (#6459) (3915661)
bump ts-api-utils to v0.0.22 (#6472) (b88cd23)
drop support for ESLint v6 (#5972) (bda806d)
drop support for node v12 (#5918) (7e3fe9a)
drop support for node v14 and test against node v20 (#7022) (e6235bf)
eslint-plugin: [prefer-nullish-coalescing]: add support for assignment expressions (#5234) (4bdbe67)
eslint-plugin: [prefer-optional-chain] handle cases where the first operands are unrelated to the rest of the chain and add type info (#6397) (02a37c4)
eslint-plugin: [prefer-readonly-parameter-types] added an optional type allowlist (#4436) (c9427b7)
eslint-plugin: [restrict-plus-operands] change checkCompoundAssignments to skipCompoundAssignments (#7027) (dc801d8)
eslint-plugin: add config that disables type-aware linting (#6470) (3b063cf)
eslint-plugin: apply final v6 changes to configs (#7110) (c13ce0b)
eslint-plugin: deprecate no-type-alias (#6229) (820bdf2)
eslint-plugin: final final config changes for v6 (#7157) (e35c5c1)
eslint-plugin: rework configs: recommended, strict, stylistic; -type-checked (#5251) (5346b5b), closes #5036 #5834 #5882 #5864 #3076 #5834 #5882 #5864 #5889 #5834 #5882 #5864 #5883 #4863 #5381 #5256 #5399
fork json schema types for better compat with ESLint rule validation (#6963) (a4967f2)
improve rule schemas, add test to validate schemas, add tooling to generate schema types (#6899) (acc1a43)
made BaseNode.parent non-optional (#5252) (a4768f3), closes #5036 #5834 #5882 #5864 #3076 #5834 #5882 #5864 #5889 #5834 #5882 #5864 #5883 #4863 #5381 #5256 #5399
remove RuleTester in /utils in favour of the new /rule-tester package (#6816) (c33f497)
remove partial type-information program (#6066) (7fc062a)
typescript-estree: add type checker wrapper APIs to ParserServicesWithTypeInformation (#6404) (62d5755)
typescript-estree: added allowInvalidAST option to not throw on invalid tokens (#6247) (a3b177d)
typescript-estree: check for illegal decorators on function declarations (#6590) (1b39cfd)
typescript-estree: check modifiers on every node (#6615) (62d6230)
typescript-estree: remove optionality from AST boolean properties (#6274) (df131e2)
typescript-estree: throw errors for object methods without function bodies (#6589) (1d78576)
typescript-estree: throw errors when abstract property has initializer (#6613) (dcdbc76)

BREAKING CHANGES

eslint-plugin: Adds an additional class of checks to the rule
drop support for ESLint v6
drops support for node v17
Bumps the minimum supported range and removes handling for old versions
drops support for node v12

You can read about our versioning strategy and releases on our website.

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

vercel · 2023-07-23T03:08:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hedvig-dot-com	✅ Ready (Inspect)	Visit Preview		Aug 8, 2023 2:25pm

robinandeer · 2023-07-25T10:55:27Z

I think we need to wait until the next eslint-config-next version is released

track: vercel/next.js#52848

guilhermespopolin · 2023-08-08T12:11:00Z

Current dependencies on/for this PR:

main
- PR fix(deps): update dependency @typescript-eslint/eslint-plugin to v6 #2844 👈

This comment was auto-generated by Graphite.

renovate · 2023-08-08T12:11:06Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

guilhermespopolin · 2023-08-08T12:44:03Z

packages/eslint-config-custom/package.json

@@ -5,7 +5,8 @@
  "main": "eslint-config-custom.js",
  "license": "MIT",
  "dependencies": {
-    "@typescript-eslint/eslint-plugin": "5.62.0",
+    "@typescript-eslint/eslint-plugin": "6.2.1",
+    "@typescript-eslint/parser": "6.2.1",


The was causing the issue: we needed to update the parser.

guilhermespopolin · 2023-08-08T12:46:25Z

packages/eslint-config-custom/eslint-config-custom.js

+    'plugin:@typescript-eslint/recommended-type-checked',
+    'plugin:@typescript-eslint/stylistic-type-checked',


We're talking about a breaking change update here.
As it can be looked in their docs they changed the way typescript-eslint is configured.

guilhermespopolin · 2023-08-08T12:51:13Z

packages/eslint-config-custom/eslint-config-custom.js

+    '@typescript-eslint/array-type': 'off',
+    '@typescript-eslint/consistent-type-definitions': 'off',
+    '@typescript-eslint/prefer-nullish-coalescing': 'off',
+    '@typescript-eslint/non-nullable-type-assertion-style': 'off',
+    '@typescript-eslint/no-redundant-type-constituents': 'off',


We're also talking about some new rules. I'm trying to disable them here just to move forward with it but we might want want to consider on enabling them and fix any issues in the future.
Now, I'm saying trying because there's some weird behaviour. Even though I'm disabling some rules in this file, the eslint rules to are still breaking. That's happening for old and new rules.

E.g: We're disabling @typescript-eslint/no-explicit-any in this file which is extended by ui, onboarding and store eslint configurations. However, eslint still complains about it.
The same happens for the new rules as well. Any hints on why is that?
@alebedev @robinandeer

guilhermespopolin · 2023-08-08T13:48:54Z

packages/eslint-config-custom/eslint-config-custom.js

@@ -76,15 +89,5 @@ module.exports = {
        '@typescript-eslint/no-var-requires': 'off',
      },
    },
-    {


@alebedev Let me know if that makes sense to be removed or if there something that I'm not foreseeing.

It was necessary evil, glad it works without it now

alebedev

Great job, let's merge!

renovate bot requested a review from a team as a code owner July 23, 2023 03:08

renovate bot added the needs approval/merge Major dependency updates, automatically added to renovate PRs. These need human approvals & merging label Jul 23, 2023

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from ae5b61c to cd5c1b1 Compare July 23, 2023 09:43

vercel bot had a problem deploying to Preview July 23, 2023 09:49 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from cd5c1b1 to a9045f8 Compare July 24, 2023 00:40

vercel bot had a problem deploying to Preview July 24, 2023 00:46 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from a9045f8 to 9964cfb Compare July 24, 2023 07:22

vercel bot had a problem deploying to Preview July 24, 2023 07:27 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 9964cfb to 1eb5215 Compare July 24, 2023 08:58

vercel bot had a problem deploying to Preview July 24, 2023 09:03 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 1eb5215 to b921a2a Compare July 25, 2023 04:20

vercel bot had a problem deploying to Preview July 25, 2023 04:25 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from b921a2a to 1b986e6 Compare July 25, 2023 09:47

vercel bot had a problem deploying to Preview July 25, 2023 09:52 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 1b986e6 to b152963 Compare July 25, 2023 11:07

vercel bot had a problem deploying to Preview July 25, 2023 11:14 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from b152963 to 379fae5 Compare July 26, 2023 11:28

vercel bot had a problem deploying to Preview July 26, 2023 11:33 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 379fae5 to 99083f1 Compare July 26, 2023 12:45

vercel bot had a problem deploying to Preview July 26, 2023 12:50 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 99083f1 to 85e9232 Compare July 26, 2023 19:57

vercel bot had a problem deploying to Preview July 26, 2023 19:59 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 85e9232 to b3cb4b5 Compare July 27, 2023 00:39

vercel bot had a problem deploying to Preview July 27, 2023 00:52 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from b3cb4b5 to fdb280c Compare July 27, 2023 03:14

vercel bot had a problem deploying to Preview July 27, 2023 03:22 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from fdb280c to 96775ae Compare July 27, 2023 07:28

vercel bot had a problem deploying to Preview July 27, 2023 07:33 Failure

vercel bot had a problem deploying to Preview August 8, 2023 06:36 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from c5b20e9 to c1fc83b Compare August 8, 2023 07:00

vercel bot had a problem deploying to Preview August 8, 2023 07:08 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 2 times, most recently from b6e06fd to 80cb20d Compare August 8, 2023 08:00

vercel bot deployed to Preview August 8, 2023 08:17 View deployment

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 80cb20d to 730b2bf Compare August 8, 2023 08:24

vercel bot had a problem deploying to Preview August 8, 2023 08:26 Failure

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 2 times, most recently from d63ac51 to 2ef0ca7 Compare August 8, 2023 08:38

vercel bot had a problem deploying to Preview August 8, 2023 08:48 Failure

guilhermespopolin force-pushed the renovate/major-typescript-eslint-monorepo branch from 2ef0ca7 to 83dc00f Compare August 8, 2023 09:59

vercel bot had a problem deploying to Preview August 8, 2023 10:03 Failure

guilhermespopolin force-pushed the renovate/major-typescript-eslint-monorepo branch from 83dc00f to fe8736c Compare August 8, 2023 12:10

vercel bot had a problem deploying to Preview August 8, 2023 12:14 Failure

guilhermespopolin force-pushed the renovate/major-typescript-eslint-monorepo branch from fe8736c to 55c3d83 Compare August 8, 2023 12:42

vercel bot had a problem deploying to Preview August 8, 2023 12:45 Failure

guilhermespopolin reviewed Aug 8, 2023

View reviewed changes

guilhermespopolin self-assigned this Aug 8, 2023

guilhermespopolin force-pushed the renovate/major-typescript-eslint-monorepo branch from 55c3d83 to fe4aae9 Compare August 8, 2023 13:42

vercel bot deployed to Preview August 8, 2023 13:47 View deployment

guilhermespopolin reviewed Aug 8, 2023

View reviewed changes

alebedev approved these changes Aug 8, 2023

View reviewed changes

fix(deps): update dependency @typescript-eslint/eslint-plugin to v6

aeaf187

guilhermespopolin force-pushed the renovate/major-typescript-eslint-monorepo branch from fe4aae9 to aeaf187 Compare August 8, 2023 14:21

vercel bot deployed to Preview August 8, 2023 14:25 View deployment

guilhermespopolin merged commit f163ef5 into main Aug 8, 2023
4 checks passed

guilhermespopolin deleted the renovate/major-typescript-eslint-monorepo branch August 8, 2023 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update dependency @typescript-eslint/eslint-plugin to v6 #2844

fix(deps): update dependency @typescript-eslint/eslint-plugin to v6 #2844

renovate bot commented Jul 23, 2023 •

edited

vercel bot commented Jul 23, 2023 •

edited

robinandeer commented Jul 25, 2023

guilhermespopolin commented Aug 8, 2023

renovate bot commented Aug 8, 2023

guilhermespopolin Aug 8, 2023

guilhermespopolin Aug 8, 2023

guilhermespopolin Aug 8, 2023

guilhermespopolin Aug 8, 2023

alebedev Aug 8, 2023

alebedev left a comment

		'plugin:@typescript-eslint/recommended-type-checked',
		'plugin:@typescript-eslint/stylistic-type-checked',

fix(deps): update dependency @typescript-eslint/eslint-plugin to v6 #2844

fix(deps): update dependency @typescript-eslint/eslint-plugin to v6 #2844

Conversation

renovate bot commented Jul 23, 2023 • edited

Release Notes

Bug Fixes

Bug Fixes

Features

Bug Fixes

Features

Bug Fixes

chore

Features

BREAKING CHANGES

Configuration

vercel bot commented Jul 23, 2023 • edited

robinandeer commented Jul 25, 2023

guilhermespopolin commented Aug 8, 2023

renovate bot commented Aug 8, 2023

Edited/Blocked Notification

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alebedev left a comment

Choose a reason for hiding this comment

renovate bot commented Jul 23, 2023 •

edited

vercel bot commented Jul 23, 2023 •

edited