fix: #4455 Pass calendarStartDay props from week to day. #4609
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4609 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 28 28
Lines 2589 2589
Branches 1091 1091
=======================================
Hits 2510 2510
Misses 79 79 ☔ View full report in Codecov by Sentry. |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
This is a very simple change and I don't see any issues with the one line change in week.jsx. I did leave a comment to improve the test added by adding an it block. Otherwise, the code looks great!
Reviewed with ❤️ by PullRequest
test/week_test.test.js
Outdated
|
|
||
| const days = container.querySelectorAll(".react-datepicker__day--selected"); | ||
|
|
||
| expect(days).toHaveLength(7); |
There was a problem hiding this comment.
Agree, can we make an explicit case to confirm this behaviour?
There was a problem hiding this comment.
it section added
There was a problem hiding this comment.
Not much to review and difficult to assess much without more context. But the test was helpful.
Reviewed with ❤️ by PullRequest
Description
Linked issue: close #4455
Problem
See issue #4455
Changes
Screenshots
To reviewers
Contribution checklist