Fix #4521: ♻️ Update ariaLabel format in month.jsx to display the selected month and year in "Month MMMM, yyyy" #4565
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@balajis-qb you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4565 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 29 29
Lines 2579 2582 +3
Branches 1069 1072 +3
=======================================
+ Hits 2470 2473 +3
Misses 109 109 ☔ View full report in Codecov by Sentry. |
|
@balajis-qb Can you review the coverage report and see if we can get full coverage on this PR? |
… and year in "Month MMMM, yyyy" Closes Hacker0x01#4521
balajis-qb
force-pushed
the
issue-4521/fix/aria-label-for-month
branch
from
233944c to
f2d61db
Compare
|
nice |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4521
Description
This PR enhances the month.jsx component to display the selected month and year in the format
Month December, 2024instead of the previous formatmonth 2024-12. This change improves the clarity and readability of the selected date for screen reader users.Changes Made:
aria-labelfor accessibility to reflect the new date formatmonthtoMonthariaLabelPrefixwhile using it inaria-labelTesting:
aria-labelformatariaLabelPrefixand nullariaLabelPrefixvalues