Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop className did not match #4126

Merged
merged 2 commits into from Jul 10, 2023
Merged

Conversation

pymc20
Copy link
Contributor

@pymc20 pymc20 commented Jul 10, 2023

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@pymc20 you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 4
- 4

50% JavaScript
50% JavaScript (tests)

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine. It doesn't fix anything a such, just removes extra whitespace from the generated class name list.

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #4126 (9ece7c0) into master (fff7773) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9ece7c0 differs from pull request most recent head 8fc5cb2. Consider uploading reports for the commit 8fc5cb2 to get more accurate results

@@           Coverage Diff           @@
##           master    #4126   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          20       20           
  Lines        1889     1889           
  Branches      457      457           
=======================================
  Hits         1784     1784           
  Misses         35       35           
  Partials       70       70           
Impacted Files Coverage Δ
src/index.jsx 91.22% <100.00%> (ø)

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4126 up until the latest commit (8fc5cb2). No further issues were found.

Reviewed by:

Image of Graham C Graham C

@martijnrusschen martijnrusschen merged commit fad509a into Hacker0x01:master Jul 10, 2023
4 checks passed
@pymc20 pymc20 deleted the classname branch July 10, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop className did not match
2 participants