chore: use https when tls is present #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuiyisong
requested review from
sunng87,
fengys1996,
MichaelScofield and
waynexia
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2671 +/- ##
===========================================
- Coverage 85.04% 84.64% -0.40%
===========================================
Files 740 740
Lines 120457 120514 +57
===========================================
- Hits 102440 102011 -429
- Misses 18017 18503 +486 |
sunng87
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
According to hyperium/tonic#1454, we would have to use
httpswhen tls config is present.Checklist
Refer to a related PR or issue link (optional)