Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relocation exclusion for file patterns like kotlin/kotlin.kotlin_builtins #1313

Merged
merged 13 commits into from
Mar 7, 2025

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Mar 6, 2025

Sorry, something went wrong.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new test case preserveKotlinBuiltins to verify that Kotlin built-in files are correctly preserved during relocation. The test creates a Kotlin JAR, adds a Kotlin built-ins file, and then uses the shadowJar task to relocate the Kotlin package while excluding the built-ins file. The test then asserts that the built-ins file is present in the output JAR and not relocated. Overall, the test seems well-structured and addresses the intended functionality.

Merge Readiness

The code changes introduce a new test case that enhances the project's testing suite. Given the absence of any identified critical or high severity issues, the pull request appears to be in good shape. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. However, I believe it is ready for merging once any minor feedback is addressed.

Goooler added 7 commits March 7, 2025 00:40
This reverts commit e943280.
…lin_builtins
@Goooler Goooler changed the title Test preserveKotlinBuiltins Fix the exclusion for file patterns like kotlin/kotlin.kotlin_builtins Mar 7, 2025
@Goooler Goooler changed the title Fix the exclusion for file patterns like kotlin/kotlin.kotlin_builtins Fix relocation exclusion for file patterns like kotlin/kotlin.kotlin_builtins Mar 7, 2025
@Goooler Goooler requested a review from Copilot March 7, 2025 05:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the changelog to document a fix for the relocation exclusion for file patterns like "kotlin/kotlin.kotlin_builtins".

  • Clarifies the fixed issue in the changelog.
  • Adds a new "Fixed" section detailing the change.

Reviewed Changes

File Description
docs/changes/README.md Added a changelog entry for the fix.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@Goooler Goooler marked this pull request as ready for review March 7, 2025 05:22
@Goooler Goooler force-pushed the g/20250307/kotlin.kotlin_builtins branch from d17d04f to 5c6b5ce Compare March 7, 2025 05:28
@Goooler Goooler enabled auto-merge (squash) March 7, 2025 06:49
@Goooler Goooler merged commit 6f1f666 into main Mar 7, 2025
7 checks passed
@Goooler Goooler deleted the g/20250307/kotlin.kotlin_builtins branch March 7, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant