Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShadowJar not being successful after includes or excludes are changed #1200

Merged
merged 7 commits into from
Jan 26, 2025

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jan 26, 2025

Closes #717.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

Sorry, something went wrong.

@Goooler Goooler changed the title Rerun ShadowJar after excludes or includes changed Fix ShadowJar not being success after includes or excludes are changed Jan 26, 2025
@Goooler Goooler requested a review from Copilot January 26, 2025 11:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/caching/ShadowJarCachingTest.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Goooler Goooler changed the title Fix ShadowJar not being success after includes or excludes are changed Fix ShadowJar not being successful after includes or excludes are changed Jan 26, 2025
@Goooler Goooler marked this pull request as ready for review January 26, 2025 11:42
@Goooler Goooler force-pushed the g/20250126/fix-exclude-include-inputs branch from e178acb to 7f1db98 Compare January 26, 2025 11:49
@Goooler Goooler enabled auto-merge (squash) January 26, 2025 11:50
@Goooler Goooler merged commit 450b831 into main Jan 26, 2025
7 checks passed
@Goooler Goooler deleted the g/20250126/fix-exclude-include-inputs branch January 26, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShadowJar task input fingerprint uses configured 'excludes'
1 participant