Replace JavaJarExec with JavaExec
#1197
Merged
+21
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Goooler
commented
Jan 26, 2025
•
Goooler
commented
- CHANGELOG's "Unreleased" section has been updated, if applicable.
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- api/shadow.api: Language not supported
- src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/ApplicationPluginTest.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/JavaJarExec.kt: Language not supported
Goooler
commented
Jan 26, 2025
Comment on lines
-51
to
+56
| it.mainClass.set("-jar") | ||
| it.classpath(jarFile) | ||
| it.mainClass.set(javaApplication.mainClass) |
There was a problem hiding this comment.
Set mainClass from javaApplication.mainClass instead of -jar and make sure the jarFile is in classpath, so that we can get rid of the args appending logic in
Also, eliminates doFirst logic in 2900592.
…a-jar-exec // Conflicts: // src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/ApplicationPluginTest.kt
Goooler
force-pushed
the
g/20250126/remove-java-jar-exec
branch
from
0c4472d to
6aa5c44
Compare
|
The newly added test in #1214 passed both before and after this change, so everything looks good. Feel free to have a post review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.