Skip to content

Commit

Permalink
meta: return to v5 of flatpak-builder workflow
Browse files Browse the repository at this point in the history
For now return to the version 5 of `flatpak-builder` workflow, until aarch64 job long execution time will be resolved.

Signed-off-by: tfuxu <73042332+tfuxu@users.noreply.github.com>
  • Loading branch information
tfuxu committed Apr 6, 2023
1 parent 0bfc938 commit 6579c69
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
with:
platforms: arm64

- uses: flatpak/flatpak-github-actions/flatpak-builder@v6
- uses: flatpak/flatpak-github-actions/flatpak-builder@v5
with:
repository-name: gnome-nightly
bundle: gradience-devel.flatpak
Expand Down

3 comments on commit 6579c69

@daudix
Copy link
Member

@daudix daudix commented on 6579c69 Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't tested the second build after push, there were two builds, one here and one in shell-theming branch, which of course uses it's own cache

image

@daudix
Copy link
Member

@daudix daudix commented on 6579c69 Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, there were long builds even with older flatpak-builder workflow

https://github.com/GradienceTeam/Gradience/actions/runs/4203630666

@kbdharun
Copy link
Contributor

@kbdharun kbdharun commented on 6579c69 Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was investigating this issue, it is due to GitHub actions which seem to provide runners for x86_64 architecture only but Flatpak builder has support for other architectures and it achieves it using QEMU, I would suggest either removing aarch64 from the workflow as it isn't supported officially here https://github.com/actions/runner-images or I would suggest not bumping flatpak builder version until GitHub actions add official support for ARM runners (Ref: actions/runner-images#5631). (Note: I am looking for alternative solutions for aarch builds so the suggestions made in this comment isn't final)

Please sign in to comment.