Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): manual upgrade of dependencies #1396

Merged
merged 3 commits into from
Dec 14, 2022
Merged

chore(deps): manual upgrade of dependencies #1396

merged 3 commits into from
Dec 14, 2022

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Dec 13, 2022 •
edited

accumulated upgrades from renovate PRs #997, #1094, #1095, #1193, #1379, #1384, #1387, #1388, #1389, #1402 and #1403.
#1193 could be merged because the latest (at the moment) version of requests (2.28.1) constraints the use of charset-normalizer to major version < 3.
#1379 could be merged because cloud-profiler-python (4.0.0) fails to work under Python 3.11

@minherz minherz self-assigned this Dec 13, 2022
@minherz minherz requested a review from a team as a code owner December 13, 2022 23:00
@mathieu-benoit
Copy link
Contributor

Current issue in CI:

The conflict is caused by:
#8 12.54     The user requested charset-normalizer==3.0.1
#8 12.54     requests 2.28.1 depends on charset-normalizer<3 and >=2

@minherz minherz force-pushed the minherz/update-dependencies branch 3 times, most recently from 51160f3 to aeb4326 Compare December 14, 2022 01:54
@minherz
Copy link
Contributor Author

minherz commented Dec 14, 2022

Current issue in CI:

The conflict is caused by:
#8 12.54     The user requested charset-normalizer==3.0.1
#8 12.54     requests 2.28.1 depends on charset-normalizer<3 and >=2

@mathieu-benoit thank you, it seems that the version upgrade required by #1193 cannot be applied to loadgenerator module. I've "returned" the charset-normalizer dependency in all back to 2.1.1 because the latest version of requests (as you pointed out) does not work with v3 of the normalizer. it seems like a bug in the renovate to push this forward.

@minherz minherz force-pushed the minherz/update-dependencies branch 4 times, most recently from ae36e2e to 0891ae2 Compare December 14, 2022 19:17
@github-actions
Copy link

🚲 PR staged at http://35.226.190.251

NimJay
NimJay approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking care of this, @minherz!
All the relevant checks are passing + the staging URL works.

Thanks for also re-regenerating the demo_pb2.py and demo_pb2_grpc.py files.
These files are now missing the Apache 2.0 license headers, but I think that's fine.

Feel free to merge (you'll need to tick the "bypass branch protection" checkbox).

@minherz
chore(deps): manual upgrade of dependencies
c812ee6 
accumulated upgrades from renovate PRs #997, #1094, #1095, #1193, #1379, #1384, #1387, #1388, #1389,
@minherz
chore(deps): fix dependencies
2b2d663 
due to requests constraint the charset-normalizer is rolled back to
lates of major version 2 (2.1.1).
add importlib-metadata dependency.
update opentelemetry-* to the version supported by 1.15.0 of the SDK.
rollback to docker 3.10 for email & recommendation cause profiler package
does not support python 3.11
regenerate email and recommendation svs protobuf
@minherz
chore(deps): adding changes from #1402 and #1403
d929e27
@github-actions
Copy link

🚲 PR staged at http://35.226.190.251

1 similar comment
@github-actions
Copy link

🚲 PR staged at http://35.226.190.251

@minherz minherz merged commit c6105db into main Dec 14, 2022
This was referenced Dec 14, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@NimJay NimJay deleted the minherz/update-dependencies branch December 14, 2022 20:53
@Nikusharoot Nikusharoot mentioned this pull request Sep 9, 2023
Open
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@minherz
chore(deps): manual upgrade of dependencies (GoogleCloudPlatform#1396)
9d043c4 
* chore(deps): manual upgrade of dependencies

accumulated upgrades from renovate PRs GoogleCloudPlatform#997, GoogleCloudPlatform#1094, GoogleCloudPlatform#1095, GoogleCloudPlatform#1193, GoogleCloudPlatform#1379, GoogleCloudPlatform#1384, GoogleCloudPlatform#1387, GoogleCloudPlatform#1388, GoogleCloudPlatform#1389,

* chore(deps): fix dependencies

due to requests constraint the charset-normalizer is rolled back to
lates of major version 2 (2.1.1).
add importlib-metadata dependency.
update opentelemetry-* to the version supported by 1.15.0 of the SDK.
rollback to docker 3.10 for email & recommendation cause profiler package
does not support python 3.11
regenerate email and recommendation svs protobuf

* chore(deps): adding changes from GoogleCloudPlatform#1402 and GoogleCloudPlatform#1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

Assignees

@minherz minherz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minherz @mathieu-benoit @NimJay