Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/hashicorp/hcl/v2 from 2.18.1 to 2.19.1 #1867

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 23, 2023

Bumps github.com/hashicorp/hcl/v2 from 2.18.1 to 2.19.1.

Release notes

Sourced from github.com/hashicorp/hcl/v2's releases.

v2.19.1

What's Changed

Full Changelog: hashicorp/hcl@v2.19.0...v2.19.1

Changelog

Sourced from github.com/hashicorp/hcl/v2's changelog.

HCL Changelog

v2.19.0 (October 16, 2023)

Enhancements

  • ext/dynblock: dynblock.Expand now supports an optional hook for calling applications to check and potentially veto (by returning error diagnostics) particular for_each values. The behavior is unchanged for callers that don't set the new option. (#634)

Bugs Fixed

  • hclsyntax: Further fixes for treatment of "marked" values in the conditional expression, and better tracking of refined values into the conditional expression results, building on the fixes from v2.18.1. (#633)
Commits
  • 341ffa4 Merge pull request #635 from hashicorp/jbardin/WithoutOptionalAttributesDeep
  • 9847e90 hcldec must use WithoutOptionalAttributesDeep
  • 925bfe8 CHANGELOG: prepare for v2.19.0 release
  • 0af4fe2 ext/dynblock: Allow callers to veto for_each values
  • 4945193 Merge pull request #633 from hashicorp/jbardin/conditional-length-refinements
  • bad33d5 further refine refinement handling
  • e4589e3 Range() calls must always be unmarked
  • 3a30333 refinements of collections must use Range()
  • 63067e8 hcldec: New test for marks+refinements together
  • 6ec7124 hclsyntax: New tests for marks+refinments together
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code release-chore To not include into release notes labels Oct 23, 2023
@tpdownes tpdownes self-assigned this Oct 23, 2023
@tpdownes tpdownes self-requested a review October 23, 2023 14:02
@tpdownes
Copy link
Member

Library continues to use MPL license.

@tpdownes
Copy link
Member

/gcbrun

Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr0re1 PTAL at hashicorp/hcl#633 and check if it affects our usage. I think some of these issues may not be detectable statically.

I will approve PR but leave it unmerged. Please merge it yourself if the changes in 633 look fine.

@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Oct 23, 2023
@tpdownes
Copy link
Member

@mr0re1 I note from the failure that this PR bumps our minimum requirement to Go 1.19. Any thoughts?

@mr0re1
Copy link
Collaborator

mr0re1 commented Oct 24, 2023

I'm up for updating it, but it may be a broking change. lets bring it up on a team meeting (as a blocking topic)

@mr0re1
Copy link
Collaborator

mr0re1 commented Oct 24, 2023

/gcbrun

@mr0re1
Copy link
Collaborator

mr0re1 commented Oct 24, 2023

@dependabot rebase

Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.18.1 to 2.19.1.
- [Release notes](https://github.com/hashicorp/hcl/releases)
- [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md)
- [Commits](hashicorp/hcl@v2.18.1...v2.19.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/hcl/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/develop/github.com/hashicorp/hcl/v2-2.19.1 branch from c51ccd4 to 7648b6b Compare October 24, 2023 19:06
@mr0re1
Copy link
Collaborator

mr0re1 commented Oct 24, 2023

/gcbrun

@tpdownes tpdownes merged commit ce373db into develop Oct 24, 2023
7 of 34 checks passed
@tpdownes tpdownes deleted the dependabot/go_modules/develop/github.com/hashicorp/hcl/v2-2.19.1 branch October 24, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants