Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(devtools): extend protocol timeout for load #15555

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

adamraine
Copy link
Member

Related #14083

Protocol timeouts are happening a lot DT smokes for oopifs:
https://github.com/GoogleChrome/lighthouse/actions/runs/6579880151/attempts/2?pr=15554

The root cause is that Lighthouse never sees network quiet, and so Lighthouse waits for maxWaitForLoad before continuing.

The problem is that oopif-requests defines maxWaitForLoad to be longer the same a the default puppeteer timeout of 180s. If Lighthouse spends 180s just waiting for load then the entire run is guaranteed to take longer than 180s. This PR extends the puppeteer timeout to 5 min to accommodate the possibility of oopif-requests hitting it's maxWaitForLoad.

@adamraine adamraine requested a review from a team as a code owner October 19, 2023 22:52
@adamraine adamraine requested review from connorjclark and removed request for a team October 19, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants