cli(sentry): set useful tags from resolved config #15485
Merged
+35
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
connorjclark
commented
Sep 19, 2023
connorjclark
commented
- Set useful things from the provided settings as tags, not extra. Only the form are queryable. Channel, form factor, and throttling method
- Resolve settings from provided config and flags. This is normally only done inside core, but we repeat the same logic inside lib/sentry.js. If it fails, just ignore and fallback to using the provided flags -- core will handle the failure for us.
connorjclark
requested review from
adamraine
and removed request for
a team
adamraine
reviewed
Sep 20, 2023
adamraine
approved these changes
Sep 20, 2023
| /** @type {LH.Config.Settings | LH.CliFlags} */ | ||
| let settings = opts.flags; | ||
| try { | ||
| const {resolvedConfig} = await initializeConfig('navigation', opts.config, opts.flags); |
There was a problem hiding this comment.
Settings could change for different modes (e.g. throttling method could override to devtools in timespan mode.
That being said, we are only using this on CLI for navigation runs so this makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.