Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log when connection to existing chrome found for requested port #291

Merged
merged 1 commit into from
Feb 9, 2023
Merged

log when connection to existing chrome found for requested port #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/chrome-launcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,11 @@ class Launcher {

// If an explict port is passed first look for an open connection...
try {
return await this.isDebuggerReady();
await this.isDebuggerReady();
log.log(
'ChromeLauncher',
`Found existing Chrome already running using port ${this.port}, using that.`);
return;
} catch (err) {
log.log(
'ChromeLauncher',
Expand Down