Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#568) Set the 'Due date' when closing a milestone if configured to do so #614

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Jericho
Copy link
Contributor

@Jericho Jericho commented Jul 27, 2024

Allow developers to set a Boolean setting indicating whether they want the due date to be set when a milestone is closed.

By default, this config setting is set to "false" to preserve the current behavior.

@Jericho
Copy link
Contributor Author

Jericho commented Jul 27, 2024

Resolves #568

Verified

This commit was signed with the committer’s verified signature.
gep13 Gary Ewan Park
This is controlled via new set-due-date value in the close section of
the GitReleaseManager.yaml file.  This operation is disabled by default,
and something which the user has to opt into to make use of.
@gep13 gep13 linked an issue Feb 20, 2025 that may be closed by this pull request
@gep13 gep13 changed the title (GH-568) Set the 'Due date' when closing a milestone if configured to do so (#568) Set the 'Due date' when closing a milestone if configured to do so Feb 20, 2025
@gep13 gep13 self-requested a review February 20, 2025 11:34
@gep13 gep13 enabled auto-merge February 20, 2025 11:34
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Feb 20, 2025

@Jericho thank you very much for getting this PR put up!

I have just taken this for a spin, both against GitHub and GitLab, and I am happy to say that this is working as expected!

Going to go ahead and get this merged in, once the CI builds complete.

We will need to update the documentation to include this new configuration option, but I will try to take care of that later today.

@gep13 gep13 merged commit e8006e2 into GitTools:develop Feb 20, 2025
2 checks passed
@Jericho Jericho deleted the set_due_date branch February 20, 2025 12:03
@gep13
Copy link
Member

gep13 commented Feb 20, 2025

@Jericho I have updated the documentation to include this new option in the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert end date when closing a milestone
2 participants