CI: Use OIDC token for codecov uploading #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After waiting for some upstream fixes (xref codecov/codecov-action#1378), now OIDC token works. |
|
Will remove the |
weiji14
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov-action v4.2.0 started to support OIDC token for uploading coverage results, so that we don't need to use secret tokens any more.
Upstream PR: codecov/codecov-action#1330
Usage: https://github.com/codecov/codecov-action#using-oidc
If it works, then we can remove the
CODECOV_TOKENsecrets from the settings.