-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons]Core Icon Revision #14154
base: main
Are you sure you want to change the base?
[Icons]Core Icon Revision #14154
Conversation
IMO the wireframe and hidden line icon is still too similar. |
It probably mixes it up more. I think changing the perfect made it much, much easier to understand. Also I don't understand this idea. Also, I looked at other programs and it usually happens like this in all of them. |
So you say this makes it easier to understand but you don't understand it? The hidden lines display the triangulated state as the geometry is rendered with Coin3D. IMO not very useful for working with solids but it's the great for meshes. |
Ok I won't lie. I never looked at this view because I thought it was similar to other CAD programs. Which I don't normally use. I've never used mesh or anything like that. Now I kneel before the greatness of FreeCad. Indeed, this appearance has turned into something useful that can be used. The downside was that I misunderstood and had to remake the entire group to make their perspectives more understandable. But it was definitely worth it. They became much more understandable. |
I like it now. Thanks. |
9c2aaa5
to
519e3fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resizing broke several alignments to the pixel grid so the smaller icons appear blurry.
I've attached some screenshots to the before/after. As mentioned, the elements and strokes should be aligned to the pixel grid to prevent aliasing and scale better.
In Inkscape you can view the grid under View -> Page grid.
src/Gui/Icons/accessories-text-editor.svg this icon is a good example how it should be, as everything is aligned.
@kadet1090 @obelisk79 FYI
Yes, pixel alignment is crucial for the icons to render properly and be sharp so it must be fixed before merging. |
Update utilities-terminal.svg Update button_add_all.svg pixel alignment Pixel alignment was performed for the specified icons.
f2084d9
to
572fb1c
Compare
Done, ready to merge. |
@maxwxyz could you please approve (or not, as the case may be!) the change you requested? |
@kadet1090 @obelisk79 could you check as well and comment? |
@obelisk79 if you would like to comment please do so, otherwise we will merge next week. |
|
The stepped line effect on the view icons is still there. Could you use the old perspective for them? |
I don't understand what you mean by the stepping line effect. |
#13840