Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver to avoid CVE #2718

Merged
merged 1 commit into from Sep 11, 2023
Merged

Update semver to avoid CVE #2718

merged 1 commit into from Sep 11, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Sep 8, 2023

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2718 (3410aa4) into main (93f90df) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2718   +/-   ##
=======================================
  Coverage   39.52%   39.52%           
=======================================
  Files         540      540           
  Lines       19130    19130           
  Branches     4523     4523           
=======================================
  Hits         7562     7562           
  Misses      11568    11568           
Flag Coverage Δ
backend 74.45% <ø> (ø)
frontend 2.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Have feedback on the report? Share it here.

@Steve-Mcl
Copy link
Contributor

@Pezmc have you ran this locally?

There was an issue some months ago with latest semver and frontend code (can't remember the exact details - we might have worked around it but I can't remember the resolution)

@Pezmc
Copy link
Contributor Author

Pezmc commented Sep 11, 2023

I believe that was #2077 which was fixed in semver version 7.5.1: npm/node-semver#559

@Steve-Mcl Steve-Mcl merged commit ab1ab07 into main Sep 11, 2023
6 checks passed
@Steve-Mcl Steve-Mcl deleted the chore-update-semver branch September 11, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants