Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice urllib3[secure] #473

Merged
merged 3 commits into from Aug 21, 2022
Merged

Conversation

fyunusa
Copy link
Contributor

@fyunusa fyunusa commented Aug 10, 2022

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with FlexMeasures

Description

pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12)
urllib3/urllib3#2680

Signed-off-by: V24 <55334829+umarfarouk98@users.noreply.github.com>
Signed-off-by: V24 <55334829+umarfarouk98@users.noreply.github.com>
Signed-off-by: V24 <55334829+umarfarouk98@users.noreply.github.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2833305627

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.562%

Totals Coverage Status
Change from base Build 2825554854: 0.0%
Covered Lines: 7205
Relevant Lines: 10091

💛 - Coveralls

@nhoening
Copy link
Contributor

Thanks for the notice, @umarfarouk98.

The .txt requirement files are generated with pip-tools. I will study what the necessary changes in .in files would need to be.

First result:

We are importing urllib3 via requests, which is needed by tldextract.
And via selenium, which is needed by timely-beliefs and sentry-sdk.

urllib3[secure]==1.26.8
    # via
    #   requests
    #   selenium
    #   sentry-sdk

It seems none of these hard-code a version requirement anywhere, so I believe there is not much we can do here, other than hard-code urllib3 in the .in files ourselves, and see if that works.

But ultimately, it seems our packaging pipeline would pick up on later urllib3 versions removing the [secure] part, by itself.

Good to see that this PR passes our test pipeline already.

@fyunusa
Copy link
Contributor Author

fyunusa commented Aug 10, 2022

You may want to retain the dependencies that were originally installed via urllib3[secure] like `idna, pyOpenSSL, certifi, etc. 

@pquentin
Copy link

requests and sentry-sdk only require urllib3, but selenium requires urllib3[secure]. We opened a pull request for Selenium: SeleniumHQ/selenium#10932. So the best course of action here could be to wait for Selenium to merge and release this, and then run pip-compile again: [secure] will go away at that point.

@nhoening
Copy link
Contributor

Thanks, all. I see the Selenium people already merged that issue, so in one of our next releases (we release every 4-6 weeks, roughly, and usually run pip-compile after each release), this will be okay. I'm merging this to honor your help.

@nhoening nhoening merged commit 8912852 into FlexMeasures:main Aug 21, 2022
@Flix6x Flix6x added this to the 0.11.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants