Use ESM #43
Merged
Use ESM #43
+66
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit switches the package over to actual ESM, it must
be imported with `import`
* The default export is the slug class, the static function is
exposed as a named export:
```js
import GithubSlugger, {slug} from 'github-slugger'
```
* This also uses an actual ES6 class instead of
prototype/constructor.
This means that you now **must** use `new` to create
an instance (it was optional before):
```js
const slugger = new GithubSlugger()
```
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 22 58 +36
=========================================
+ Hits 22 58 +36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wooorm
commented
Oct 26, 2022
| @@ -1,25 +0,0 @@ | |||
| const test = require('tape') | |||
There was a problem hiding this comment.
Inlined this file above, and dropped some unneeded tests
|
Checking it out now! |
Flet
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importnewto create an instance (it was optional before):/cc @Flet