Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update redis #20

Merged
merged 3 commits into from Apr 24, 2023
Merged

chore(deps): update redis #20

merged 3 commits into from Apr 24, 2023

Conversation

jguillon
Copy link
Contributor

Description

A security issue affected redis-py package. As users, we would like to be able to use dramatiq-abort with more recent version of redis-py (>=4.3.6).

Fixes #19

Checklist

  • I have performed tests using the tox command.

@isra17
Copy link
Member

isra17 commented Apr 22, 2023

Seems like a new version of the linter is unhappy with our code:

  ./src/dramatiq_abort/backends/__init__.py:8:5: B028 No explicit stacklevel keyword argument found. The warn method from the warnings module uses a stacklevel of 1 by default. This will only show a stack trace for the line on which the warn method is called. It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.

Would you mind adding a stacklevel=2 to the warning call?

@isra17 isra17 merged commit b5e0835 into Flared:master Apr 24, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies
2 participants