hygiene: run the demo through pagekit compilation #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes hand-rolled demo compilation in favour of the pagekit standard. This should mean if the demo works, next-article will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hygiene: run the demo through pagekit compilation
NOTE FOR REVIEWERS: this update makes no changes to the module code itself, only to update its demo and jest configurations to match that of next-article. Consequently, merging this PR does not require a release.
What
Removes hand-rolled demo compilation in favour of using pagekit plugins.
Why
By using pagekit plugins, we create a consistent compilation configuration between the demo in n-magnet and the applications that consume it (at the moment just next-article).
Historically, n-magnet was created before the era of pagekit, and when its predecessor n-ui had extremely limited jsx support. So it had to all be hand-rolled. That is no-longer the case so this update accounts for that fact.