Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so that git verification works on Apple git versions #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joannaskao
Copy link
Member

Apple's git version looks like git version 2.21.0 (Apple Git-122)
rather than just git version 2.24.0

Apple's git version looks like `git version 2.21.0 (Apple Git-122)`
rather than just `git version 2.24.0`
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #31 into master will decrease coverage by 1.69%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #31     +/-   ##
========================================
- Coverage      80%   78.3%   -1.7%     
========================================
  Files           1       4      +3     
  Lines          70     106     +36     
  Branches       24      32      +8     
========================================
+ Hits           56      83     +27     
- Misses          4       9      +5     
- Partials       10      14      +4
Impacted Files Coverage Δ
src/util.ts 69.23% <100%> (ø)
src/vault.ts 85.71% <0%> (ø)
src/help.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35bf51b...29cff90. Read the comment docs.

Copy link
Member

@aendra-rininsland aendra-rininsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants