Update App to React Native 0.72 version #18507
Conversation
melvin-bot
bot
requested review from
aimane-chnaif and
MariaHCD
and removed request for
a team
|
@aimane-chnaif @MariaHCD One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Update✅ Web and Desktop builds are working at a first glance. ❌ Android and iOS builds are totally broken. Trying to run After some investigation, it seems that v0.72.0-rc.1-alpha.0 release is broken. First evidence is that it is incredibly small (only 27 MBs) compared to previous one. Second evidence is that its source files are wrong, missing files and scripts necessary to build the project (hence the errors above). It looks like the sources must be built from We have our own publish-npm-expensify.js file to build the sources for our fork, but this change isn't there and is likely the reason for the broken release. So, I changed every path in the file to point to @roryabraham I will raise a PR to Expensify's RN fork with these changes for you to review it, which branch do I have to target? We are probably going to need another release to continue with the RN update. |
|
Normally I would say you should target the latest release |
|
@roryabraham I created a branch from the latest tag, here is the changes. Which branch should I target for the PR? |
…t-native libraries
Update
Android build errorslottie-react-native
@onfido/react-native-sdk
react-native-reanimated
iOS build errorsDidn't investigate yet. |
There was a problem hiding this comment.
Temporary patch to fix Android build. Must be removed when an upstream fix is available.
There was a problem hiding this comment.
Upstream PR: onfido/react-native-sdk#130
|
@fabioh8010 with the reanmiated changes feel free to post in #open-source channel and tag Tomek Zawadski and we might get help from them. I will try to ask Rory for help in terms of the branch |
|
I can help with resolving |
|
@fabioh8010 I noticed that the |
There was a problem hiding this comment.
Temporary patch to fix iOS build. Must be removed when a new Expensify RN release is available.
There was a problem hiding this comment.
I prepared PR for it Expensify/react-native#54.
@roryabraham would you mind including this in the new RN release if it gets approved?
Update✅ All platforms are building now.
@mountiny I guess that at this point now we can start involving QA to help test the application and find problems. |
I'll prepare PR for our fork to fix it as well |
Screenshots🔲 iOS / nativeScreen.Recording.2023-08-02.at.1.27.01.AM-sm.mp4🔲 iOS / SafariScreen.Recording.2023-08-02.at.8.03.40.PM.mov🔲 MacOS / DesktopScreen.Recording.2023-08-02.at.1.01.49.AM.mov🔲 MacOS / ChromeScreen.Recording.2023-08-02.at.12.09.04.AM.movScreen.Recording.2023-08-02.at.12.06.14.AM2.mov🔲 Android / ChromeScreen.Recording.2023-08-02.at.8.16.29.PM.mov🔲 Android / nativeScreen.Recording.2023-08-02.at.6.36.25.AM.mp4Screen.Recording.2023-08-02.at.6.40.47.AM.mp4 |
|
Tested new builds. Still looks good except this known bug. |
|
Checking a few strange things and I will complete the checklist tomorrow. Almost everything works. |
|
Update: There are merge conflicts again, but let's wait until #24036 is merged because we are having a crash in the app on Context -> #20179 (comment) and https://expensify.slack.com/archives/C049HHMV9SM/p1690954042805659 EDIT: #24036 was merged, working on solving merge conflicts and tests. |
|
So, I found a few inconsistencies but those are also present on the main so all good. I agree there are some issues with text wrapping and clipping but that is something that can be done in follow-up issues. The main thing is that app is working. SVG, Animations, Composer, Selection menu, Textinputs, rendering, etc... |
|
Let me know main is merged, I will approve it. |
|
@parasharrajat I've updated against |
|
Rebuilding and doing a quick checkup. |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
| @@ -61,7 +61,7 @@ function WorkspaceBillsFirstSection(props) { | |||
| containerStyles={[styles.cardSection]} | |||
| > | |||
| <View style={[styles.mv3]}> | |||
| <Text numberOfLines={100}> | |||
There was a problem hiding this comment.
Is there a reason for this?
There was a problem hiding this comment.
@parasharrajat Context -> #18507 (comment)
| // TODO: remove this commend once upstream PR is merged | ||
| maximumNumberOfLines={maximumNumberOfLines} | ||
| // TODO: remove this comment once upstream PR is merged and available in a future release | ||
| maxNumberOfLines={maxNumberOfLines} |
There was a problem hiding this comment.
These seem like coming from upstream changes. Is this not applicable to web?
There was a problem hiding this comment.
@parasharrajat This is done in a different way in Web, these upstream PR is only for native.
|
All yours @aimane-chnaif and the team. Let's get this before a new conflict pops up. cc: @mountiny @roryabraham |
|
|
from me.
There was a problem hiding this comment.
Both @roryabraham and @mountiny are ooo, so I reviewed this PR to get it out sooner rather than later.
|
Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
I am still not able to build android locally - #18507 (comment). |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.50-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀
|
| - csv.enabled = true | ||
| + xml.required = true | ||
| + html.required = true | ||
| + csv.required = true |
There was a problem hiding this comment.
@fabioh8010 can I have context of why this is changed?
Because I am going to undo this change while bumping onfido sdk version (to fix #35519) if it's safe to remove.
There was a problem hiding this comment.
Oh sorry, this was already replaced in 10.5.0. So no longer this patch is needed as I am bumping to 10.6.0
There was a problem hiding this comment.
It's explained in this PR that I made to their repo, not sure if it's still necessary though.
Details
This PR aims to update Expensify's App to use our RN 0.72 fork. Some changes were made in order to follow upgrading from previous RN version to current one, following this steps.
SLACK DISCUSSION THREAD: https://expensify.slack.com/archives/C01GTK53T8Q/p1683321604215369
Patches created and corresponding upstream PRs
Fixed Issues
$ #18444
$ #21308
PROPOSAL: -
Tests
Full regression test
Offline tests
Same as above.
QA Steps
Same as above.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android