Add support for generated @deprecated arguments from @GraphQLDeprecated #2075
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Mar 10, 2025
...erator/src/main/kotlin/com/expediagroup/graphql/generator/internal/types/generateArgument.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Can you also update docs under https://opensource.expediagroup.com/graphql-kotlin/docs/schema-generator/customizing-schemas/deprecating-schema to indicate that we can use @GraphQLDeprecated for deprecating arguments?
Updated the docs! let me know if that's a good format to show that |
|
@samuelAndalon can you take a look? |
samuelAndalon
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR enables support for using the
@GraphQLDeprecatedannotation on arguments, allowing the generated GraphQL schema to include the@deprecateddirective.Changes:
generateArgument.ktto mark argument as deprecated if the DeprecationReason is present.Why?
The GraphQL spec now officially supports applying
@deprecatedon arguments, enabling better API evolution without breaking existing clients. This change aligns the library with the latest spec, giving developers a built-in way to signal argument deprecations.🔗 Related Issues
#1361