-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update dependencies #1974
Conversation
nit: we probably don't need to pin the coverage values to the exact ones, i.e. we should have some wiggle room when making some trivial changes |
Thanks for the PR! |
@@ -10,6 +10,7 @@ dependencies { | |||
api(projects.graphqlKotlinClientJackson) | |||
api(libs.kotlinx.coroutines.reactor) | |||
api(libs.spring.webflux) | |||
api(libs.spring.context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need explicit spring context dependency here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring changed their dependency management I guess 🤷
:graphql-kotlin-spring-client:compileTestKotlin
Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
class org.springframework.http.client.reactive.ReactorClientHttpConnector, unresolved supertypes: org.springframework.context.SmartLifecycle
I reverted the new values except where the difference was too big. |
Updates
Added
Improvements
TODO
./gradlew ktlintFormat