Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default ets table type to set, and make configurable #38

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Change default ets table type to set, and make configurable #38

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d710a9
Change default ets table type to `set`, and make configurable
Dec 5, 2018
be7ca53
Document the `:ets_table_type` option
Dec 5, 2018
bbac67a
Add link to mnesia backend
Jan 3, 2019
c8135c3
Merge branch 'master' into sk-change-ets-table-to-set
epinault Aug 31, 2023
6c5c4fe
Update ets.ex
epinault Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/hammer/backend/ets.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ defmodule Hammer.Backend.ETS do
- `expiry_ms`: (integer) time in ms before a bucket is auto-deleted,
should be larger than the expected largest size/duration of a bucket
- `cleanup_interval_ms`: (integer) time between cleanup runs,
- `ets_table_type`: (atom) type of ETS table, defaults to `:set`, and can be
either `:set` or `:ordered_set`

Example:

Expand Down Expand Up @@ -160,6 +162,7 @@ defmodule Hammer.Backend.ETS do
def init(args) do
cleanup_interval_ms = Keyword.get(args, :cleanup_interval_ms)
expiry_ms = Keyword.get(args, :expiry_ms)
ets_table_type = Keyword.get(args, :ets_table_type, :set)

if !expiry_ms do
raise RuntimeError, "Missing required config: expiry_ms"
Expand All @@ -169,9 +172,13 @@ defmodule Hammer.Backend.ETS do
raise RuntimeError, "Missing required config: cleanup_interval_ms"
end

if ets_table_type not in [:set, :ordered_set] do
raise RuntimeError, "Invalid config: ets_table_type '#{ets_table_type}'"
end

case :ets.info(@ets_table_name) do
:undefined ->
:ets.new(@ets_table_name, [:named_table, :ordered_set, :public])
:ets.new(@ets_table_name, [:named_table, ets_table_type, :public])
:timer.send_interval(cleanup_interval_ms, :prune)

_ ->
Expand Down