Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron: unsafeParse now throws a more informative error instead of a … #4333

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

gcanti
Copy link
Contributor

@gcanti gcanti commented Jan 23, 2025

…generic one

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…generic one
@gcanti gcanti requested a review from fubhy January 23, 2025 17:07
@gcanti gcanti requested a review from mikearnaldi as a code owner January 23, 2025 17:07
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 7ad8e52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster-browser Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch
@effect/ai Patch
@effect/ai-openai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fubhy
Copy link
Member

fubhy commented Jan 23, 2025

Oh wow. I expected getOrThrow to do that already.

@gcanti gcanti merged commit 712277f into main Jan 24, 2025
12 checks passed
@gcanti gcanti deleted the cron-unsafeParse branch January 24, 2025 05:29
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants