Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Readable & Subscribable modules #2472

Merged
merged 5 commits into from
Apr 8, 2024
Merged

add Readable & Subscribable modules #2472

merged 5 commits into from
Apr 8, 2024

Conversation

tim-smart
Copy link
Contributor

No description provided.

@tim-smart tim-smart requested a review from mikearnaldi as a code owner April 4, 2024 20:45
Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: 8892a68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@effect/experimental Patch
effect Patch
@effect/cli Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi
Copy link
Member

Maybe a Readable with the get and Subscribable as a sub-type of Readable?

@tim-smart
Copy link
Contributor Author

I was thinking about it, but Readable just seems like Effect<A>.

@mikearnaldi
Copy link
Member

I was thinking about it, but Readable just seems like Effect<A>.

if we want Ref & co to implement it it needs to be a { get }

@tim-smart tim-smart changed the title add Subscribable trait / module add Readable & Subscribable modules Apr 7, 2024
@jessekelly881
Copy link
Contributor

jessekelly881 commented Apr 7, 2024

Effect could probably implement Readable as well. get get(){ return this } (same with Option and Either). I wonder if there might not be circularity issues though..

@tim-smart
Copy link
Contributor Author

Effect could probably implement Readable as well. get get(){ return this } (same with Option and Either). I wonder if there might not be circularity issues though..

Hmm doesn't make too much sense to me, as Readable / Ref is supposed to represent a handle to some mutable value. Effect represents a computation.

@tim-smart tim-smart merged commit 8709856 into main Apr 8, 2024
12 checks passed
@tim-smart tim-smart deleted the subscribable branch April 8, 2024 23:26
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants