add BigInt.fromString and BigInt.fromNumber #2399
Merged
+121
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e946010 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
coleea
changed the title
fubhy
previously requested changes
Mar 24, 2024
packages/effect/src/Number.ts
Outdated
Comment on lines
504
to
507
| * @param s - The string to be converted to a `number`. | ||
| * @returns An `Option` type that is either `some(number)` if the string can be converted | ||
| * to a valid number, or `none` if the string is empty or contains invalid characters | ||
| * for number conversion. |
There was a problem hiding this comment.
Suggested change
| * @param s - The string to be converted to a `number`. | |
| * @returns An `Option` type that is either `some(number)` if the string can be converted | |
| * to a valid number, or `none` if the string is empty or contains invalid characters | |
| * for number conversion. | |
| * @param s - The string to be converted to a `number`. |
Redundant (repetition of function description)
|
@fubhy thank you. I applied your change-request |
tim-smart
requested changes
Mar 24, 2024
tim-smart
requested changes
Mar 24, 2024
tim-smart
requested changes
Mar 24, 2024
tim-smart
changed the title
tim-smart
requested changes
Mar 25, 2024
tim-smart
reviewed
Mar 25, 2024
tim-smart
approved these changes
Mar 25, 2024
|
@tim-smart @fubhy thank you for patience 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
According to #1766 , I added 4 functions.
Number.fromString
Number.fromBigInt
BigInt.fromString
BigInt.fromNumber
I changed
numbervariable inNumber.tstonumber_for usingNumber.MAX_SAFE_INTEGERandNumber.MIN_SAFE_INTEGERRelated