-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow inheritdoc for class constructors with base types #3719
Merged
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2d5a62f
Allow inheritdoc for constructors with base types
MartyIX 7cd2b05
Fix
MartyIX ef223ab
Another approach
MartyIX d58dede
Improve implementation
MartyIX 836540c
Remove #nullable enable from the test
MartyIX 62237f3
SA1648InheritDocMustBeUsedWithInheritingClass: Enable NRT
MartyIX 49d59ce
Move up and use `declaredSymbol`
MartyIX b7d10a8
Split tests
MartyIX fd402ad
Address review comments
MartyIX 5ecef98
Add a test for ArgumentException (type from a different assembly)
MartyIX 31643cf
Test records as well
MartyIX 50a5fbf
Struct case
MartyIX 3ca55e3
Merge branch 'master' into issue2575
MartyIX 182e0a7
Revert "Struct case"
MartyIX 0ebb990
Simplify
MartyIX 7183ec0
Simplify?
MartyIX db794b0
more tests
MartyIX 858e7a1
Merge branch 'master' into issue2575
MartyIX 80804ab
Increase test timeout to 80 minutes
sharwell 3800377
Merge branch 'master' into issue2575
MartyIX 6e752bb
Feedback
MartyIX File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😕 Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's on Visual Studio. Not me. Obviously. ;) Removed.