-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate @types/prettier
since v3.0.0
#66073
Deprecate @types/prettier
since v3.0.0
#66073
Conversation
👋 folks, I might need some advice here. The catalog contains two packages which depend on We can upgrade UPD: Possibly fixed in 9dff4fd |
@kachkaev Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 3 packages in this PR (and infra files)
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66073,
"author": "kachkaev",
"headCommitOid": "5b9263e89ed75ad2d30449f9551e01b107fc3db2",
"mergeBaseOid": "91371d885c35452617a571c10cea5210e9e725d5",
"lastPushDate": "2023-07-15T09:41:10.000Z",
"lastActivityDate": "2023-07-29T15:26:36.000Z",
"mergeOfferDate": "2023-07-29T14:55:11.000Z",
"mergeRequestDate": "2023-07-29T15:26:36.000Z",
"mergeRequestUser": "kachkaev",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "babel-plugin-tester",
"kind": "edit",
"files": [
{
"path": "types/babel-plugin-tester/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"ifiokjr",
"mathieutu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "prettier",
"kind": "delete",
"files": [
{
"path": "types/prettier/doc.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/index.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-angular.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-babel.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-espree.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-flow.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-glimmer.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-graphql.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-html.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-markdown.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-meriyah.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-postcss.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-typescript.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/parser-yaml.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/prettier-tests.ts",
"kind": "test"
},
{
"path": "types/prettier/standalone.d.ts",
"kind": "definition"
},
{
"path": "types/prettier/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/prettier/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"ikatyang",
"ifiokjr",
"ffflorian",
"sosukesuzuki",
"Shinigami92",
"thorn0",
"JounQin",
"shian15810",
"marcgibbons"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "pretty-quick",
"kind": "edit",
"files": [
{
"path": "types/pretty-quick/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-07-29T14:54:25.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "sandersn",
"date": "2023-07-25T17:16:57.000Z",
"abbrOid": "9dff4fd"
},
{
"type": "stale",
"reviewer": "jakebailey",
"date": "2023-07-25T15:32:55.000Z",
"abbrOid": "9dff4fd"
}
],
"mainBotCommentID": 1636724779,
"ciResult": "pass"
} |
🔔 @ifiokjr @mathieutu @ikatyang @ffflorian @sosukesuzuki @Shinigami92 @thorn0 @JounQin @shian15810 @marcgibbons @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
@kachkaev The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@kachkaev One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Re-ping @ifiokjr, @mathieutu, @ikatyang, @ffflorian, @sosukesuzuki, @Shinigami92, @thorn0, @JounQin, @shian15810, @marcgibbons, @peterblazejewicz: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
@sandersn, @jakebailey, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
1 similar comment
@sandersn, @jakebailey, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kachkaev thanks!
@sandersn, @jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Ready to merge |
npm test <package to test>
.If removing a declaration:
notNeededPackages.json
.Context
@types/prettier
to this repository prettier/prettier#14212prettier@3.0.0
on unpkgSteps