Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @types/prettier since v3.0.0 #66073

Merged

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Jul 15, 2023

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

Context

Steps

git clone https://github.com/DefinitelyTyped/DefinitelyTyped.git --sparse --filter=blob:none --depth=10
cd DefinitelyTyped
git sparse-checkout add types/prettier
git sparse-checkout add scripts
npm run not-needed -- prettier 3.0.0

## create branch, commit and push

## https://github.com/DefinitelyTyped/DefinitelyTyped/pull/66073#discussion_r1264381682

## push one more time

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Jul 15, 2023
@kachkaev
Copy link
Contributor Author

kachkaev commented Jul 15, 2023

👋 folks, I might need some advice here. The catalog contains two packages which depend on prettier: babel-plugin-tester and pretty-quick. If we remove types/prettier, tests start failing in them.

We can upgrade prettier to v3 in the whole repo, but that can create a massive diff. Happy to do that if that’s the only way forward, but what if there are other ways to make CI for babel-plugin-tester and pretty-quick happy?

UPD: Possibly fixed in 9dff4fd

@kachkaev kachkaev marked this pull request as ready for review July 15, 2023 09:54
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 15, 2023

@kachkaev Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

3 packages in this PR (and infra files)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66073,
  "author": "kachkaev",
  "headCommitOid": "5b9263e89ed75ad2d30449f9551e01b107fc3db2",
  "mergeBaseOid": "91371d885c35452617a571c10cea5210e9e725d5",
  "lastPushDate": "2023-07-15T09:41:10.000Z",
  "lastActivityDate": "2023-07-29T15:26:36.000Z",
  "mergeOfferDate": "2023-07-29T14:55:11.000Z",
  "mergeRequestDate": "2023-07-29T15:26:36.000Z",
  "mergeRequestUser": "kachkaev",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "babel-plugin-tester",
      "kind": "edit",
      "files": [
        {
          "path": "types/babel-plugin-tester/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ifiokjr",
        "mathieutu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "prettier",
      "kind": "delete",
      "files": [
        {
          "path": "types/prettier/doc.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-angular.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-babel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-espree.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-flow.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-glimmer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-graphql.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-html.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-markdown.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-meriyah.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-postcss.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-typescript.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/parser-yaml.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/prettier-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/prettier/standalone.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/prettier/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/prettier/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ikatyang",
        "ifiokjr",
        "ffflorian",
        "sosukesuzuki",
        "Shinigami92",
        "thorn0",
        "JounQin",
        "shian15810",
        "marcgibbons"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "pretty-quick",
      "kind": "edit",
      "files": [
        {
          "path": "types/pretty-quick/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-07-29T14:54:25.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "sandersn",
      "date": "2023-07-25T17:16:57.000Z",
      "abbrOid": "9dff4fd"
    },
    {
      "type": "stale",
      "reviewer": "jakebailey",
      "date": "2023-07-25T15:32:55.000Z",
      "abbrOid": "9dff4fd"
    }
  ],
  "mainBotCommentID": 1636724779,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 15, 2023

🔔 @ifiokjr @mathieutu @ikatyang @ffflorian @sosukesuzuki @Shinigami92 @thorn0 @JounQin @shian15810 @marcgibbons @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

@kachkaev The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jul 15, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jul 15, 2023
package.json Outdated Show resolved Hide resolved
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jul 15, 2023
package.json Outdated Show resolved Hide resolved
@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jul 23, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Author Action in New Pull Request Status Board Jul 23, 2023
@typescript-bot
Copy link
Contributor

@kachkaev One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Revision needed This PR needs code changes before it can be merged. labels Jul 29, 2023
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 29, 2023

Re-ping @ifiokjr, @mathieutu, @ikatyang, @ffflorian, @sosukesuzuki, @Shinigami92, @thorn0, @JounQin, @shian15810, @marcgibbons, @peterblazejewicz:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jul 29, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jul 29, 2023
@typescript-bot
Copy link
Contributor

@sandersn, @jakebailey, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

1 similar comment
@typescript-bot
Copy link
Contributor

@sandersn, @jakebailey, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@kachkaev thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jul 29, 2023
@typescript-bot
Copy link
Contributor

@kachkaev: Everything looks good here. I am ready to merge this PR (at 5b9263e) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Jul 29, 2023
@typescript-bot
Copy link
Contributor

@sandersn, @jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@kachkaev
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jul 29, 2023
@typescript-bot typescript-bot merged commit a9deb23 into DefinitelyTyped:master Jul 29, 2023
2 checks passed
@kachkaev kachkaev deleted the deprecate-prettier-typings branch July 29, 2023 15:27
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants