Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @wordpress/components since types from DT since they have been bundled #65213

Conversation

noahtallen
Copy link
Contributor

@noahtallen noahtallen commented Apr 19, 2023

Removes @wordpress/components types, since the package now bundles them. (see WordPress/gutenberg#49229)

Also introduces a wordpress components dependency for other types packages which were relying on the DT types. (As a result, I bumped the other wordpress package versions as well, since they should typically come from the same "release")

Note that many of these other packages may be removed soon as well.

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 19, 2023

@noahtallen Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

6 packages in this PR (and infra files)

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ❌ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65213,
  "author": "noahtallen",
  "headCommitOid": "2265984ca7ee600bfea0bbdb8fd669a2024ab5a9",
  "mergeBaseOid": "a1e05446f15e547c687129d0da07a15a4e0121eb",
  "lastPushDate": "2023-04-19T22:49:30.000Z",
  "lastActivityDate": "2023-04-21T22:38:48.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "wordpress__block-editor",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__block-editor/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__block-editor/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__blocks",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__blocks/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__blocks/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell",
        "tomasztunik",
        "sunyatasattva",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__components",
      "kind": "delete",
      "files": [
        {
          "path": "types/wordpress__components/angle-picker-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/animate/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/autocomplete/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/base-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/button-group/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/body/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/divider/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/footer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/header/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/card/media/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/checkbox-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/clipboard-button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/color-indicator/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/color-palette/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/color-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/combobox-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/custom-select-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/dashicon/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/date-time/date.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/date-time/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/date-time/time.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/disabled/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/draggable/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/drop-zone/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/drop-zone/provider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/dropdown-menu/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/dropdown/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/external-link/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/flex/block.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/flex/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/flex/item.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/focal-point-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/focusable-iframe/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/font-size-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/form-file-upload/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/form-toggle/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/form-token-field/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/guide/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/navigate-regions/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-constrained-tabbing/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-fallback-styles/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-filters/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-focus-outside/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-focus-return/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-notices/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/higher-order/with-spoken-messages/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/icon-button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/icon/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/isolated-event-container/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/keyboard-shortcuts/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/menu-group/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/menu-item/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/menu-items-choice/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/modal/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/navigable-container/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/navigable-container/menu.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/navigable-container/tabbable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/notice/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/notice/list.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__components/panel/body.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/panel/header.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/panel/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/panel/row.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/placeholder/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/popover/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/block-quotation/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/horizontal-rule/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/primitives/svg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/query-controls/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/radio-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/range-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/resizable-box/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/responsive-wrapper/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/sandbox/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/scroll-lock/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/select-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/shortcut/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/context.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/fill.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/slot-fill/slot.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/snackbar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/snackbar/list.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/spinner/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tab-panel/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/text-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/textarea-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tip/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toggle-control/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toolbar-button/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toolbar-group/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/toolbar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tooltip/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tree-select/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__components/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/wordpress__components/ui/context/wordpress-component.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/visually-hidden/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/wordpress__components-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "p-jackson",
        "sarayourfriend",
        "michaelhthomas",
        "manzoorwanijk",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__edit-post",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__edit-post/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__edit-post/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__editor",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__editor/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__editor/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__plugins",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__plugins/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__plugins/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1513950947,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/2265984ca7ee600bfea0bbdb8fd669a2024ab5a9/checks?check_suite_id=12354825028"
}

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Edits Infrastructure labels Apr 19, 2023
@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Apr 19, 2023
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 19, 2023

🔔 @dsifford @sirreal @dmsnell @tomasztunik @sunyatasattva @bastolen @p-jackson @sarayourfriend @michaelhthomas @manzoorwanijk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

@noahtallen Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@noahtallen noahtallen changed the title Remove @wordpress/components types now that it bundles types Remove @wordpress/components since types from DT since they have been bundled Apr 19, 2023
@noahtallen noahtallen force-pushed the remove-unused-wp-components-types branch from 55fe662 to fc8f00d Compare April 19, 2023 00:30
@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Apr 19, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2023
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 19, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 19, 2023
@typescript-bot
Copy link
Contributor

@noahtallen The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Edits multiple packages and removed The CI failed When GH Actions fails labels Apr 19, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2023
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 19, 2023
@typescript-bot
Copy link
Contributor

@noahtallen The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@noahtallen
Copy link
Contributor Author

This is now blocked by adding @wordpress/components as an allowed dependency here: microsoft/DefinitelyTyped-tools#665

@noahtallen
Copy link
Contributor Author

Alright, that was added, so hopefully this will work now 😁

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Apr 19, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 19, 2023
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 19, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 19, 2023
@typescript-bot
Copy link
Contributor

@noahtallen The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@noahtallen
Copy link
Contributor Author

I'm pausing this, since we hope to remove a lot of the existing packages anyways. (So making them work in this PR would be wasted!)

@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Apr 27, 2023
@typescript-bot
Copy link
Contributor

@noahtallen Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot
Copy link
Contributor

@noahtallen I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on May 21st (in a week) if the issues aren't addressed.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label May 15, 2023
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board May 23, 2023
@typescript-bot
Copy link
Contributor

@noahtallen To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Edits Infrastructure Edits multiple packages Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. The CI failed When GH Actions fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants