Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gapi.client.*] Bulk update Google API namespace #65077

Merged
merged 1 commit into from Apr 12, 2023

Conversation

Maxim-Mazurok
Copy link
Contributor

@Maxim-Mazurok Maxim-Mazurok commented Apr 11, 2023

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

As seen previously in https://github.com/DefinitelyTyped/DefinitelyTyped/pulls?q=is%3Apr+sort%3Aupdated-desc+author%3AMaxim-Mazurok+is%3Aclosed+gapi.client

@Maxim-Mazurok
Copy link
Contributor Author

Depends on microsoft/DefinitelyTyped-tools#664

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 11, 2023

@Maxim-Mazurok Thank you for submitting this PR!

This is a live comment which I will keep updated.

31 packages in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65077,
  "author": "Maxim-Mazurok",
  "headCommitOid": "bf83aabdf82c732f2f1e2eada22eb33957478ec2",
  "mergeBaseOid": "74f39f2f20779a9668754974fe699c2364393fd7",
  "lastPushDate": "2023-04-12T01:28:48.000Z",
  "lastActivityDate": "2023-04-12T03:14:32.000Z",
  "mergeOfferDate": "2023-04-12T02:43:04.000Z",
  "mergeRequestDate": "2023-04-12T03:14:32.000Z",
  "mergeRequestUser": "Maxim-Mazurok",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "gapi.client.acmedns-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.acmedns-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.acmedns-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.acmedns-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.acmedns-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.advisorynotifications-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.advisorynotifications-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.advisorynotifications-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.advisorynotifications-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.advisorynotifications-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.baremetalsolution-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.baremetalsolution-v1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.baremetalsolution-v1alpha1",
      "kind": "delete",
      "files": [
        {
          "path": "types/gapi.client.baremetalsolution-v1alpha1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.baremetalsolution-v1alpha1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.bigqueryreservation-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.bigqueryreservation-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudbuild-v1alpha1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudbuild-v1alpha1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudbuild-v1alpha2",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudbuild-v1alpha2/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudbuild-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudbuild-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudprofiler-v2",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudprofiler-v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.datalineage-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.datalineage-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.datalineage-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.datalineage-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.datalineage-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.firebaseappdistribution-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.googleads-v13",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.googleads-v13/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.googleads-v13/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.googleads-v13/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.googleads-v13/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.homegraph-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.homegraph-v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.iam-v2",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.iam-v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.iam-v2/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.iam-v2/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.iam-v2/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.ideahub-v1alpha",
      "kind": "delete",
      "files": [
        {
          "path": "types/gapi.client.ideahub-v1alpha/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.ideahub-v1alpha/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.ideahub-v1beta",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.ideahub-v1beta/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.kmsinventory-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.kmsinventory-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.kmsinventory-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.kmsinventory-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.kmsinventory-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.language-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.language-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.migrationcenter-v1alpha1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.notebooks-v2",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.notebooks-v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.notebooks-v2/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.notebooks-v2/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.notebooks-v2/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.policysimulator-v1beta",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.policysimulator-v1beta/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.policysimulator-v1beta/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.policysimulator-v1beta/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.policysimulator-v1beta/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.policysimulator-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.policysimulator-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.publicca-v1alpha1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.publicca-v1alpha1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.publicca-v1alpha1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1alpha1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1alpha1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.publicca-v1beta1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.publicca-v1beta1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.publicca-v1beta1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1beta1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1beta1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.readerrevenuesubscriptionlinking-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.searchads360-v0",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.searchads360-v0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.searchads360-v0/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.searchads360-v0/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.searchads360-v0/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.tasks-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.tasks-v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vmmigration-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.vmmigration-v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vmmigration-v1alpha1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.vmmigration-v1alpha1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vpcaccess-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.vpcaccess-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vpcaccess-v1beta1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-04-12T02:41:18.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1503393817,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Edits multiple packages Untested Change This PR does not touch tests Check Config Changes a module config files labels Apr 11, 2023
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 11, 2023

@Maxim-Mazurok Thank you for submitting this PR!

This is a live comment which I will keep updated.

31 packages in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65077,
  "author": "Maxim-Mazurok",
  "headCommitOid": "bf83aabdf82c732f2f1e2eada22eb33957478ec2",
  "mergeBaseOid": "74f39f2f20779a9668754974fe699c2364393fd7",
  "lastPushDate": "2023-04-12T01:28:48.000Z",
  "lastActivityDate": "2023-04-12T03:14:32.000Z",
  "mergeOfferDate": "2023-04-12T02:43:04.000Z",
  "mergeRequestDate": "2023-04-12T03:14:32.000Z",
  "mergeRequestUser": "Maxim-Mazurok",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "gapi.client.acmedns-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.acmedns-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.acmedns-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.acmedns-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.acmedns-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.advisorynotifications-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.advisorynotifications-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.advisorynotifications-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.advisorynotifications-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.advisorynotifications-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.baremetalsolution-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.baremetalsolution-v1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.baremetalsolution-v1alpha1",
      "kind": "delete",
      "files": [
        {
          "path": "types/gapi.client.baremetalsolution-v1alpha1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.baremetalsolution-v1alpha1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.bigqueryreservation-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.bigqueryreservation-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudbuild-v1alpha1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudbuild-v1alpha1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudbuild-v1alpha2",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudbuild-v1alpha2/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudbuild-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudbuild-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.cloudprofiler-v2",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.cloudprofiler-v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.datalineage-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.datalineage-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.datalineage-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.datalineage-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.datalineage-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.firebaseappdistribution-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.firebaseappdistribution-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.googleads-v13",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.googleads-v13/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.googleads-v13/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.googleads-v13/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.googleads-v13/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.homegraph-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.homegraph-v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.iam-v2",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.iam-v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.iam-v2/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.iam-v2/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.iam-v2/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.ideahub-v1alpha",
      "kind": "delete",
      "files": [
        {
          "path": "types/gapi.client.ideahub-v1alpha/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.ideahub-v1alpha/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.ideahub-v1beta",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.ideahub-v1beta/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.kmsinventory-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.kmsinventory-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.kmsinventory-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.kmsinventory-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.kmsinventory-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.language-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.language-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.migrationcenter-v1alpha1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.migrationcenter-v1alpha1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.notebooks-v2",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.notebooks-v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.notebooks-v2/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.notebooks-v2/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.notebooks-v2/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.policysimulator-v1beta",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.policysimulator-v1beta/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.policysimulator-v1beta/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.policysimulator-v1beta/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.policysimulator-v1beta/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.policysimulator-v1beta1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.policysimulator-v1beta1/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.publicca-v1alpha1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.publicca-v1alpha1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.publicca-v1alpha1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1alpha1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1alpha1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.publicca-v1beta1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.publicca-v1beta1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.publicca-v1beta1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1beta1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.publicca-v1beta1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.readerrevenuesubscriptionlinking-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.readerrevenuesubscriptionlinking-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.searchads360-v0",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.searchads360-v0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.searchads360-v0/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.searchads360-v0/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.searchads360-v0/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.tasks-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.tasks-v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vmmigration-v1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.vmmigration-v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vmmigration-v1alpha1",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.vmmigration-v1alpha1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vpcaccess-v1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.vpcaccess-v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vpcaccess-v1beta1",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.vpcaccess-v1beta1/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-04-12T02:41:18.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1503393817,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 11, 2023
@typescript-bot
Copy link
Contributor

Hey @Maxim-Mazurok,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @namoscato @declanvong — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 11, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Apr 11, 2023
@typescript-bot
Copy link
Contributor

@Maxim-Mazurok The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@jakebailey jakebailey closed this Apr 11, 2023
@jakebailey jakebailey reopened this Apr 11, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 12, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 12, 2023
@typescript-bot
Copy link
Contributor

@jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 12, 2023
@typescript-bot
Copy link
Contributor

@Maxim-Mazurok: Everything looks good here. I am ready to merge this PR (at bf83aab) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Apr 12, 2023
@Maxim-Mazurok
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Apr 12, 2023
@typescript-bot typescript-bot merged commit 0aafd04 into DefinitelyTyped:master Apr 12, 2023
2 checks passed
@Maxim-Mazurok Maxim-Mazurok deleted the update branch April 12, 2023 04:38
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files Edits multiple packages Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants