Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use workaround for labeler sync-labels bug #13015

Merged
merged 1 commit into from Sep 26, 2022
Merged

Use workaround for labeler sync-labels bug #13015

merged 1 commit into from Sep 26, 2022

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Sets config sync-labels to "" in order to workaround bug in the labeler action.

actions/labeler#112 (comment)

Motivation

Fix PR labeler action from removing manually added labels.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@fanny-jiang fanny-jiang requested review from a team as code owners September 26, 2022 20:41
@ghost ghost added the dev/tooling label Sep 26, 2022
ofek
ofek approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@fanny-jiang fanny-jiang merged commit 235307b into master Sep 26, 2022
@fanny-jiang fanny-jiang deleted the fanny/labeler-sync-workaround branch September 26, 2022 20:58
steveny91 pushed a commit that referenced this pull request Oct 27, 2022
@fanny-jiang @steveny91
workaround sync-labels bug (#13015)
52bbf8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
dev/tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fanny-jiang @ofek