ci(starlette): unpin sqlalchemy in framework tests [backport #4801 to 1 7] #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description The starlette framework tests currently pin sqlalchemy to 1.4.41 due to an upstream issue which has now closed: encode/databases#512. It looks like we can unpin this dependency. Note: this also indirectly fixes the failing starlette framework tests due to this now closed upstream issue: encode/databases#513, where sqlalchemy==1.4.42 added a new private field in the SQLAlchemy cursor class. While this job uses the latest databases package that has accounted for this field, this was causing attribute errors since we were using a previous version of sqlalchemy that did not yet have that private field added. <!-- If this is a breaking change, explain why it is necessary. Breaking changes must append `!` after the type/scope. See https://ddtrace.readthedocs.io/en/stable/contributing.html for more details. --> ## Checklist - [ ] Followed the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) when writing a release note. - [ ] Add additional sections for `feat` and `fix` pull requests. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. <!-- Copy and paste the relevant snippet based on the type of pull request --> <!-- START feat --> ## Motivation <!-- Expand on why the change is required, include relevant context for reviewers --> ## Design <!-- Include benefits from the change as well as possible drawbacks and trade-offs --> ## Testing strategy <!-- Describe the automated tests and/or the steps for manual testing. <!-- END feat --> <!-- START fix --> ## Relevant issue(s) <!-- Link the pull request to any issues related to the fix. Use keywords for links to automate closing the issues once the pull request is merged. --> ## Testing strategy <!-- Describe any added regression tests and/or the manual testing performed. --> <!-- END fix --> ## Reviewer Checklist - [x] Title is accurate. - [x] Description motivates each change. - [x] No unnecessary changes were introduced in this PR. - [x] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Tests provided or description of manual testing performed is included in the code or PR. - [x] Release note has been added and follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines), or else `changelog/no-changelog` label added. - [x] All relevant GitHub issues are correctly linked. - [x] Backports are identified and tagged with Mergifyio.
mabdinur
changed the title
mabdinur
added
the
changelog/no-changelog
mabdinur
force-pushed
the
backport-4801-to-1-7
branch
from
812fe21
to
8278686
Compare
brettlangdon
approved these changes
Dec 22, 2022
Yun-Kim
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport: #4801
The starlette framework tests currently pin sqlalchemy to 1.4.41 due to
an upstream issue which has now closed:
encode/databases#512. It looks like we can
unpin this dependency.
Note: this also indirectly fixes the failing starlette framework tests
due to this now closed upstream issue:
encode/databases#513, where sqlalchemy==1.4.42
added a new private field in the SQLAlchemy cursor class. While this job
uses the latest databases package that has accounted for this field,
this was causing attribute errors since we were using a previous version
of sqlalchemy that did not yet have that private field added.
Checklist
guidelines
when writing a release note.
featandfixpull requests.documentation
and/or Datadog's documentation
site is updated. Link to doc
PR in description.
Motivation
Design
Testing strategy
Relevant issue(s)
Testing strategy
Reviewer Checklist
API
changes unless absolutely necessary.
included in the code or PR.
guidelines,
or else
changelog/no-changeloglabel added.